From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1THIOg-0000Y8-87
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 14:01:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1THIOZ-0000xb-A6
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 14:01:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:7586)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1THIOZ-0000xT-2Q
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 14:01:07 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RI16lN014929
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 27 Sep 2012 14:01:06 -0400
Message-ID: <50649460.3010200@redhat.com>
Date: Thu, 27 Sep 2012 14:01:04 -0400
From: Jeff Cody <jcody@redhat.com>
MIME-Version: 1.0
References: <cover.1348760202.git.jcody@redhat.com>
	<327f7d715621f55ee9d1dfd0a3eba6138ffe9345.1348760202.git.jcody@redhat.com>
	<5064936E.70301@redhat.com>
In-Reply-To: <5064936E.70301@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 5/6] QAPI: add command for live block
	commit, 'block-commit'
Reply-To: jcody@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org

On 09/27/2012 01:57 PM, Eric Blake wrote:
> On 09/27/2012 11:29 AM, Jeff Cody wrote:
>> The command for live block commit is added, which has the following
>> arguments:
>>
>> device: the block device to perform the commit on (mandatory)
>> base:   the base image to commit into; optional (if not specified,
>>         it is the underlying original image)
>> top:    the top image of the commit - all data from inside top down
>>         to base will be committed into base (mandatory for now; see
>>         note, below)
>>
> 
>> +++ b/qmp-commands.hx
>> @@ -792,6 +792,12 @@ EQMP
>>      },
>>  
>>      {
>> +        .name       = "block-commit",
>> +        .args_type  = "device:B,base:s?,top:s?,speed:o?",
> 
> s/top:s?/top:s/ now that top is mandatory.
> 

Right, forgot the hx file.  Although, QAPI catches it just fine
regardless of the hx file... but I will spin that really quick
(hopefully that is the only change required), unless Kevin wants to do
it when he pulls it into his branch.