From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49370)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1THJFD-0007LB-Mx
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 14:55:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1THJF8-0002SI-15
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 14:55:31 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:53846)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1THJF7-0002Pe-Qx
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 14:55:25 -0400
Received: by pbbrp2 with SMTP id rp2so4017592pbb.4
	for <qemu-devel@nongnu.org>; Thu, 27 Sep 2012 11:55:24 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5064A11A.80207@twiddle.net>
Date: Thu, 27 Sep 2012 11:55:22 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1348766113-18373-1-git-send-email-aurelien@aurel32.net>
	<1348766113-18373-7-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1348766113-18373-7-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/13] tcg: improve tcg_reg_alloc_movi()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> +++ b/tcg/tcg.c
> @@ -1658,6 +1658,9 @@ static void tcg_reg_alloc_movi(TCGContext *s, const TCGArg *args,
>      if (NEED_SYNC_ARG(0)) {
>          temp_sync(s, args[0], s->reserved_regs);
>      }
> +    if (IS_DEAD_ARG(0)) {
> +        temp_dead(s, args[0]);
> +    }
>  }

Same comment re ordering the DEAD/SYNC tests.  Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~