From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38144)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1THJWj-0007vu-Vx
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 15:13:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1THJWa-0008WS-Fc
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 15:13:37 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:39900)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1THJWa-0008WL-94
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 15:13:28 -0400
Received: by pbbrp2 with SMTP id rp2so4040218pbb.4
	for <qemu-devel@nongnu.org>; Thu, 27 Sep 2012 12:13:27 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5064A555.4080501@twiddle.net>
Date: Thu, 27 Sep 2012 12:13:25 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1348766113-18373-1-git-send-email-aurelien@aurel32.net>
	<1348766113-18373-11-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1348766113-18373-11-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/13] tcg: don't explicitely save globals
 and temps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

On 09/27/2012 10:15 AM, Aurelien Jarno wrote:
> @@ -1706,11 +1718,9 @@ static void tcg_reg_alloc_mov(TCGContext *s, const TCGOpDef *def,
>          if (!ots->mem_allocated) {
>              temp_allocate_frame(s, args[0]);
>          }
> -        if (ts->val_type == TEMP_VAL_REG) {
> -            tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> -            if (IS_DEAD_ARG(1)) {
> -                temp_dead(s, args[1]);
> -            }
> +        tcg_out_st(s, ots->type, ts->reg, ots->mem_reg, ots->mem_offset);
> +        if (IS_DEAD_ARG(1)) {
> +            temp_dead(s, args[1]);
>          }
>          temp_dead(s, args[0]);
>      } else if (ts->val_type == TEMP_VAL_CONST) {

Did this hunk belong to a different patch?  It seems like it belongs
with the tcg_reg_alloc_mov rewrite.

If it actually depends on patches 7-8, then perhaps a reorder is better.


r~