From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THK0e-0000Mc-10 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 15:44:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THK0Z-000244-W0 for qemu-devel@nongnu.org; Thu, 27 Sep 2012 15:44:31 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:60483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THK0Z-00023y-Ow for qemu-devel@nongnu.org; Thu, 27 Sep 2012 15:44:27 -0400 Received: by pbbrp2 with SMTP id rp2so4077350pbb.4 for ; Thu, 27 Sep 2012 12:44:26 -0700 (PDT) Sender: Richard Henderson Message-ID: <5064AC98.50604@twiddle.net> Date: Thu, 27 Sep 2012 12:44:24 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348766113-18373-1-git-send-email-aurelien@aurel32.net> <1348766113-18373-13-git-send-email-aurelien@aurel32.net> In-Reply-To: <1348766113-18373-13-git-send-email-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/13] tcg: fix some op flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 09/27/2012 10:15 AM, Aurelien Jarno wrote: > Some branch related ops are marked with TCG_OPF_SIDE_EFFECTS, some other > not. In practice they don't need to, as they are all marked with > TCG_OPF_BB_END, which is handled specifically in all the code. > > The call op is marked as TCG_OPF_SIDE_EFFECTS, which might be not true > as there is are specific flags (TCG_CALL_CONST and TCG_CALL_PURE) for > specifying that. On the other hand it always clobber arguments, so mark > it as such even if the call op is handled in a different code path. > > Signed-off-by: Aurelien Jarno Reviewed-by: Richard Henderson r~