From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33598)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1THKkS-0002OE-4p
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 16:31:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1THKkR-0001WV-8Q
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 16:31:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1THKkR-0001VZ-05
	for qemu-devel@nongnu.org; Thu, 27 Sep 2012 16:31:51 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8RKVnaC002391
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 27 Sep 2012 16:31:50 -0400
Message-ID: <5064B7B2.2080608@redhat.com>
Date: Thu, 27 Sep 2012 16:31:46 -0400
From: Jeff Cody <jcody@redhat.com>
MIME-Version: 1.0
References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com>
	<1348675011-8794-10-git-send-email-pbonzini@redhat.com>
	<506446F5.7060605@redhat.com>
In-Reply-To: <506446F5.7060605@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete
 to block_job_completed
Reply-To: jcody@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 09/27/2012 08:30 AM, Kevin Wolf wrote:
> Am 26.09.2012 17:56, schrieb Paolo Bonzini:
>> The imperative will be used for the QMP command.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> I would still be glad if we found a better name. Having two functions
> block_job_complete() and block_job_completed() sounds like a great
> source for confusion.
> 
> Kevin
> 

If I understand correctly, what we have is:

block_job_completed(): cleans up when a job is done
block_job_complete(): requests that a block job be completed

How about renaming both of them, respectively, to:

block_job_cleanup():  cleans up when a job is done
block_job_request_completion(): requests that a block job be completed

I think that would remove any ambiguity.