From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THNEl-0003iu-4i for qemu-devel@nongnu.org; Thu, 27 Sep 2012 19:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THNEk-0005K2-6e for qemu-devel@nongnu.org; Thu, 27 Sep 2012 19:11:19 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:54076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THNEk-0005Jy-0O for qemu-devel@nongnu.org; Thu, 27 Sep 2012 19:11:18 -0400 Received: by pbbrp2 with SMTP id rp2so4289528pbb.4 for ; Thu, 27 Sep 2012 16:11:17 -0700 (PDT) Sender: Richard Henderson Message-ID: <5064DD13.2060506@twiddle.net> Date: Thu, 27 Sep 2012 16:11:15 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1348766113-18373-1-git-send-email-aurelien@aurel32.net> <1348766113-18373-14-git-send-email-aurelien@aurel32.net> <5064AF5B.2050704@twiddle.net> <20120927203711.GO20151@ohm.aurel32.net> <5064CC6F.90806@twiddle.net> <20120927230805.GA22257@hall.aurel32.net> In-Reply-To: <20120927230805.GA22257@hall.aurel32.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/13] tcg: rework TCG ops flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org On 09/27/2012 04:08 PM, Aurelien Jarno wrote: >> > In which case, because the non-qemu store insns cannot raise exceptions, >> > there ought to be exactly zero instances of TCG_OPF_SIDE_EFFECTS remaining. >> > At which point we simply ought to remove it. >> > > I don't understand, the qemu/load store still need to keep this > TCG_OPF_SIDE_EFFECTS. Even a load to a dead output argument might > trigger a TLB miss exception, and thus should be fixed. Ah, true. r~