Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2012-9-27 18:17, Paolo Bonzini 写道:
> Il 27/09/2012 11:56, Wenchao Xia ha scritto:
>>>
>>>> +$(LIBQBLOCK_TEST_DIR):
>>>> +    @echo "Make libqblock test directory"
>>>> +    mkdir $(LIBQBLOCK_TEST_DIR)
>>>
>>> You can leave the files in tests/ directly, and avoid this as well.
>>    Having a new directory will make clean easier, otherwise the script
>> will need to know each image file names created, whose filename are
>> generated in test C code at runtime.
>
> If you want a subdirectory for images, you can create it in the test code.
>
   My original idea is creating and deleting them in C test code, but I
found that there is many "assert" in the code, which may cause the clean
step missing. So I think it is simpler to clean them in Makefile, make
sure the temporal files are deleted.

> Paolo
>


-- 
Best Regards

Wenchao Xia