From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THQsX-00074S-2Q for qemu-devel@nongnu.org; Thu, 27 Sep 2012 23:04:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THQsW-0006S4-2U for qemu-devel@nongnu.org; Thu, 27 Sep 2012 23:04:37 -0400 Received: from e28smtp01.in.ibm.com ([122.248.162.1]:40693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THQsV-0006Rn-Fh for qemu-devel@nongnu.org; Thu, 27 Sep 2012 23:04:36 -0400 Received: from /spool/local by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Sep 2012 08:34:32 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8S34UAP38600876 for ; Fri, 28 Sep 2012 08:34:30 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8S34USw010118 for ; Fri, 28 Sep 2012 13:04:30 +1000 Message-ID: <506513BB.7080600@linux.vnet.ibm.com> Date: Fri, 28 Sep 2012 11:04:27 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348712642-4427-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50640E8F.2000003@redhat.com> <506422CD.2040406@linux.vnet.ibm.com> <506427AD.70608@redhat.com> In-Reply-To: <506427AD.70608@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org 于 2012-9-27 18:17, Paolo Bonzini 写道: > Il 27/09/2012 11:56, Wenchao Xia ha scritto: >>> >>>> +$(LIBQBLOCK_TEST_DIR): >>>> + @echo "Make libqblock test directory" >>>> + mkdir $(LIBQBLOCK_TEST_DIR) >>> >>> You can leave the files in tests/ directly, and avoid this as well. >> Having a new directory will make clean easier, otherwise the script >> will need to know each image file names created, whose filename are >> generated in test C code at runtime. > > If you want a subdirectory for images, you can create it in the test code. > My original idea is creating and deleting them in C test code, but I found that there is many "assert" in the code, which may cause the clean step missing. So I think it is simpler to clean them in Makefile, make sure the temporal files are deleted. > Paolo > -- Best Regards Wenchao Xia