From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45298)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1THVJP-0006C5-9I
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:48:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1THVJH-00053R-9e
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:48:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1THVJH-00053G-1K
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:48:31 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8S7mTVj015357
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 28 Sep 2012 03:48:29 -0400
Message-ID: <50655651.1080500@redhat.com>
Date: Fri, 28 Sep 2012 09:48:33 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-19-git-send-email-quintela@redhat.com>
	<50619979.4080206@redhat.com> <87y5juob49.fsf@elfo.mitica>
In-Reply-To: <87y5juob49.fsf@elfo.mitica>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 18/41] buffered_file: opaque is
	MigrationState
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org

On 09/28/2012 09:33 AM, Juan Quintela wrote:
> Orit Wasserman <owasserm@redhat.com> wrote:
>> On 09/21/2012 11:47 AM, Juan Quintela wrote:
>>> It always have that type, just change it.
>>> -QEMUFile *qemu_fopen_ops_buffered(void *opaque, size_t xfer_limit,
>>> +QEMUFile *qemu_fopen_ops_buffered(MigrationState *migration_state,
>>> +                                  size_t xfer_limit,
>>>                                    BufferedPutFunc *put_buffer,
>>>                                    BufferedPutReadyFunc *put_ready,
>>>                                    BufferedWaitForUnfreezeFunc *wait_for_unfreeze,
>>>
>> Again why ? this is a general buffered file not just for migration use.
> 
> It is not used for anything else.  It is used only, and inlining it
> removes one level of indirection.  All wins on my book.
> 
> Notice that once the migration-thread patches end, this file basically
> dissapears (its only reason to exist was to allow non-blocking writes").
> 
yes I read the second series and get it now (maybe more details in the commit comment can help).

Cheers,
Orit
> Later, Juan.
>