From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THVND-00089B-Ix
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:52:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THVNC-0006eq-Ck
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:52:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10235)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THVNC-0006ek-4L
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 03:52:34 -0400
Message-ID: <5065573D.2000102@redhat.com>
Date: Fri, 28 Sep 2012 09:52:29 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1348712642-4427-5-git-send-email-xiawenc@linux.vnet.ibm.com>
	<50640E8F.2000003@redhat.com> <506422CD.2040406@linux.vnet.ibm.com>
	<506427AD.70608@redhat.com> <506513BB.7080600@linux.vnet.ibm.com>
In-Reply-To: <506513BB.7080600@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org

Il 28/09/2012 05:04, Wenchao Xia ha scritto:
>>>>> +$(LIBQBLOCK_TEST_DIR):
>>>>> +    @echo "Make libqblock test directory"
>>>>> +    mkdir $(LIBQBLOCK_TEST_DIR)
>>>>
>>>> You can leave the files in tests/ directly, and avoid this as well.
>>>    Having a new directory will make clean easier, otherwise the script
>>> will need to know each image file names created, whose filename are
>>> generated in test C code at runtime.
>>
>> If you want a subdirectory for images, you can create it in the test
>> code.
>>
>   My original idea is creating and deleting them in C test code, but I
> found that there is many "assert" in the code, which may cause the clean
> step missing. So I think it is simpler to clean them in Makefile, make
> sure the temporal files are deleted.

Yes, you can mkdir() in the test code, and delete the whole directory
from the Makefile.

Paolo