From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THXAr-0003BR-S4 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 05:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THXAq-0005EU-Rs for qemu-devel@nongnu.org; Fri, 28 Sep 2012 05:47:57 -0400 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:33012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THXAq-0005EK-AX for qemu-devel@nongnu.org; Fri, 28 Sep 2012 05:47:56 -0400 Received: from /spool/local by e23smtp02.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Sep 2012 19:45:52 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8S9cMQm7471108 for ; Fri, 28 Sep 2012 19:38:23 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8S9lnAt027480 for ; Fri, 28 Sep 2012 19:47:49 +1000 Message-ID: <506571EE.6090003@linux.vnet.ibm.com> Date: Fri, 28 Sep 2012 17:46:22 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348712642-4427-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50640E8F.2000003@redhat.com> <506422CD.2040406@linux.vnet.ibm.com> <506427AD.70608@redhat.com> <506513BB.7080600@linux.vnet.ibm.com> <5065573D.2000102@redhat.com> In-Reply-To: <5065573D.2000102@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V4 4/5] libqblock test build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org 于 2012-9-28 15:52, Paolo Bonzini 写道: > Il 28/09/2012 05:04, Wenchao Xia ha scritto: >>>>>> +$(LIBQBLOCK_TEST_DIR): >>>>>> + @echo "Make libqblock test directory" >>>>>> + mkdir $(LIBQBLOCK_TEST_DIR) >>>>> >>>>> You can leave the files in tests/ directly, and avoid this as well. >>>> Having a new directory will make clean easier, otherwise the script >>>> will need to know each image file names created, whose filename are >>>> generated in test C code at runtime. >>> >>> If you want a subdirectory for images, you can create it in the test >>> code. >>> >> My original idea is creating and deleting them in C test code, but I >> found that there is many "assert" in the code, which may cause the clean >> step missing. So I think it is simpler to clean them in Makefile, make >> sure the temporal files are deleted. > > Yes, you can mkdir() in the test code, and delete the whole directory > from the Makefile. > Ok, I got your idea. > Paolo > -- Best Regards Wenchao Xia