From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THXEV-0004iF-Lc for qemu-devel@nongnu.org; Fri, 28 Sep 2012 05:51:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THXEQ-0006kM-0F for qemu-devel@nongnu.org; Fri, 28 Sep 2012 05:51:43 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:51363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THXEP-0006k8-QS for qemu-devel@nongnu.org; Fri, 28 Sep 2012 05:51:37 -0400 Received: by padfb10 with SMTP id fb10so2142650pad.4 for ; Fri, 28 Sep 2012 02:51:36 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <50657321.2030100@redhat.com> Date: Fri, 28 Sep 2012 11:51:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1346916100-12958-1-git-send-email-kraxel@redhat.com> <1346916100-12958-11-git-send-email-kraxel@redhat.com> In-Reply-To: <1346916100-12958-11-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/14] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Alon Levy , qemu-devel@nongnu.org Il 06/09/2012 09:21, Gerd Hoffmann ha scritto: > +#ifndef CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC > +/* spice-protocol is too old, add missing definitions */ > +#define QXL_IO_MONITORS_CONFIG_ASYNC (QXL_IO_FLUSH_RELEASE + 1) > +#endif > + I don't see the need for this, why can't you just bump the minimum required version of spice-protocol? Or import the headers (and only the headers) in QEMU? Also, please consider adding the library version in the spice-protocol header files, so that you do not need CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC at all. Paolo