From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THYCs-00039I-GY for qemu-devel@nongnu.org; Fri, 28 Sep 2012 06:54:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THYCm-0003c3-Q9 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 06:54:06 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:58914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THYCm-0003bv-89 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 06:54:00 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Sep 2012 20:52:24 +1000 Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q8SAiQd36422590 for ; Fri, 28 Sep 2012 20:44:27 +1000 Received: from d23av02.au.ibm.com (loopback [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q8SArq40014494 for ; Fri, 28 Sep 2012 20:53:52 +1000 Message-ID: <50658187.5000402@linux.vnet.ibm.com> Date: Fri, 28 Sep 2012 18:52:55 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348712642-4427-3-git-send-email-xiawenc@linux.vnet.ibm.com> <50640D90.7040005@redhat.com> <506421E8.2020105@linux.vnet.ibm.com> <50642765.7090900@redhat.com> <506512B8.5090903@linux.vnet.ibm.com> <5065571C.3030505@redhat.com> In-Reply-To: <5065571C.3030505@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V4 2/5] libqblock type defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com 于 2012-9-28 15:51, Paolo Bonzini 写道: > Il 28/09/2012 05:00, Wenchao Xia ha scritto: >>> >>> >>> uint64_t qblock_get_virt_size(QBlockFmtInfo *fmt); >>> QBlockProtInfo *qblock_get_backing_loc(QBlockFmtInfo *fmt); >>> bool qblock_get_encrypt(QBlockFmtInfo *fmt); >>> >>> etc. that include the switch statement. >>> >> I think it is reasonable use generic accessors instead of embbed >> structure, maybe an additional helper function should be added as: >> >> QBlockStaticInfoAddr *qblock_get_static_info_addr(QBlockStaticInfo >> *info) >> >> In this way only one switch statement is needed in source code, >> and only one new API is added. > > No problem for the implementation, but please make this function static. > > Paolo > Do you mean declaring it as static function? I think user may need call it to get information so it need to be public. -- Best Regards Wenchao Xia