From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THYHK-0004V8-Jk for qemu-devel@nongnu.org; Fri, 28 Sep 2012 06:58:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THYHE-0005KN-W5 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 06:58:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10266) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THYHE-0005Jw-O0 for qemu-devel@nongnu.org; Fri, 28 Sep 2012 06:58:36 -0400 Message-ID: <506582D5.5000503@redhat.com> Date: Fri, 28 Sep 2012 12:58:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348712642-4427-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348712642-4427-3-git-send-email-xiawenc@linux.vnet.ibm.com> <50640D90.7040005@redhat.com> <506421E8.2020105@linux.vnet.ibm.com> <50642765.7090900@redhat.com> <506512B8.5090903@linux.vnet.ibm.com> <5065571C.3030505@redhat.com> <50658187.5000402@linux.vnet.ibm.com> In-Reply-To: <50658187.5000402@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 2/5] libqblock type defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com Il 28/09/2012 12:52, Wenchao Xia ha scritto: >> No problem for the implementation, but please make this function static. > > Do you mean declaring it as static function? I think user may need > call it to get information so it need to be public. The user can use the accessors. Let's not add a function to the public interface until we're 101% sure it is a good idea. Paolo