From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THYJa-0005vR-Dz
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 07:01:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THYJU-0006SY-LC
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 07:01:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38490)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1THYJU-0006Rm-DU
	for qemu-devel@nongnu.org; Fri, 28 Sep 2012 07:00:56 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8SB0t3E002724
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 28 Sep 2012 07:00:55 -0400
Message-ID: <50658365.40403@redhat.com>
Date: Fri, 28 Sep 2012 13:00:53 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348675011-8794-1-git-send-email-pbonzini@redhat.com>
	<1348675011-8794-10-git-send-email-pbonzini@redhat.com>
	<506446F5.7060605@redhat.com> <5064B7B2.2080608@redhat.com>
In-Reply-To: <5064B7B2.2080608@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 09/45] block: rename block_job_complete
 to block_job_completed
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: jcody@redhat.com
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

Il 27/09/2012 22:31, Jeff Cody ha scritto:
> 
> block_job_completed(): cleans up when a job is done

It also raises a BLOCK_JOB_COMPLETED event.

> block_job_complete(): requests that a block job be completed
> 
> How about renaming both of them, respectively, to:
> 
> block_job_cleanup():  cleans up when a job is done
> block_job_request_completion(): requests that a block job be completed
> 
> I think that would remove any ambiguity.

I'll keep this patch for now, since it doesn't introduce any ambiguity yet.

I could rename block_job_complete to block_job_request_completion as you
suggested, but it would be inconsistent with the QMP command
block-job-complete, so there are downsides as well.

Paolo