From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THaCN-00014Q-Oy for qemu-devel@nongnu.org; Fri, 28 Sep 2012 09:01:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1THaCE-0007e9-4e for qemu-devel@nongnu.org; Fri, 28 Sep 2012 09:01:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1THaCD-0007dy-Rp for qemu-devel@nongnu.org; Fri, 28 Sep 2012 09:01:34 -0400 Message-ID: <50659FAB.7020909@redhat.com> Date: Fri, 28 Sep 2012 07:01:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348752509-1142-1-git-send-email-lcapitulino@redhat.com> <1348752509-1142-14-git-send-email-lcapitulino@redhat.com> <50657DC5.9000205@redhat.com> In-Reply-To: <50657DC5.9000205@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig636FFCA04C2BDD3917709EB5" Subject: Re: [Qemu-devel] [PULL 13/15] qmp: qmp_send_key(): accept key codes in hex List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig636FFCA04C2BDD3917709EB5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 09/28/2012 04:36 AM, Amos Kong wrote: > On 27/09/12 21:28, Luiz Capitulino wrote: >> >=20 > Sorry the delay review. >=20 >=20 > hex isn't support when using qmp monitor. >=20 >> +{ 'union': 'KeyValue', >> + 'data': { >> + 'number': 'int', >=20 > It's 'int' not hex format. Indeed - I just re-read the JSON overview at http://www.json.org/, which is explicit that numbers are decimal only (no octal or hexadecimal support, and no support for a leading 0 except when the number is exactly 0). [Serves me right for not realizing this aspect of JSON when I did my review earlier.] I don't think this invalidates the QMP (libvirt already sends decimal, and wasn't planning on sending hex), but you DO have a point that: >=20 > qmp-commands.hx also needs to be updated with latest examples: Since this is already in the PULL request, I think the docs touchup could be a separate patch. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig636FFCA04C2BDD3917709EB5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQZZ+rAAoJEKeha0olJ0Nq+lIH/R616A9Xmp1Yy4k5SITzjJ4T nqvip0vT2k0JSNTLkzJUCKgX3OQ9DnpVjCdMXnIV71KQDureX331yemwkGWCQFfz yWQlQ+EPIqAwjMuh0k0L4vs3lU2e8YaaAX4Gok0/DDm1/SghKqtgZSyVOC+sLdt7 0DVVmJh45L/UQE8M1SBMHi9Ts8IgeBokHV3+wVSko4xE0SbdGBsYlUWDjFJgC6KF v9ACBNODkfpmfUBVWrr2PxwQ6rmRkW/cy8DPk6+eGRbFTr5iaf3bs4XmYvrHNme4 AWXgIG5JgYlNYyoBXxx7WyyCvgvx2cDqCekVz3gqE7ICbIuUNRAOzr58N6TR0o4= =xE4C -----END PGP SIGNATURE----- --------------enig636FFCA04C2BDD3917709EB5--