From: Alexander Graf <agraf@suse.de>
To: Dmitry Ilyevsky <ilyevsky@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] TBL register permissions for PPC
Date: Fri, 26 Mar 2010 02:15:48 +0100 [thread overview]
Message-ID: <5065CF29-421A-4C92-9043-718D4EBDB867@suse.de> (raw)
In-Reply-To: <4aa8564b1003251731o2e0dc66ci603cefa86d70d87@mail.gmail.com>
On 26.03.2010, at 01:31, Dmitry Ilyevsky wrote:
> On Thu, Mar 25, 2010 at 10:53 AM, Alexander Graf <agraf@suse.de> wrote:
>>
>> On 24.03.2010, at 22:56, Dmitry Ilyevsky wrote:
>>
>>>
>>> Hello All,
>>>
>>> Please review patch for TBL SPR read access for generic PPC.
>>>
>>> Description:
>>>
>>> POWER specification docs define TBL/TBU SPRs as readable in user and privileged modes. Therefore SPRs permissions were changed in gen_tbl function in target-ppc/translate_init.c file.
>>>
>>> Testing:
>>>
>>> Tested with vxworks-6.2 bsp and OS on custom qemu board that includes ppc405 emulated core
>>
>> A couple of comments to this patch.
>>
>> 1) Please don't top-post.
>> 2) Always put a Signed-off-by: in the patch
>> 3) Put the patch description into the patch, so git knows what to do with it
>> 4) Don't use html features in mail :-)
>>
>> The patch looks good otherwise.
>>
>>
>> Alex
>>
>>
>
> Corrected.
>
> Thanks,
> Dmitry I.
> <0001-Generic-PowerPC-TBL.patch>
Acked-by: Alexander Graf <agraf@suse.de>
next prev parent reply other threads:[~2010-03-26 1:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 18:33 [Qemu-devel] TBL register permissions for PPC Dima Ilyevsky
2009-12-01 19:28 ` Krumme, Chris
2009-12-01 23:23 ` Alexander Graf
2009-12-01 23:35 ` malc
2010-03-24 21:56 ` Dmitry Ilyevsky
2010-03-25 7:53 ` Alexander Graf
2010-03-26 0:31 ` Dmitry Ilyevsky
2010-03-26 1:15 ` Alexander Graf [this message]
2010-03-26 22:42 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065CF29-421A-4C92-9043-718D4EBDB867@suse.de \
--to=agraf@suse.de \
--cc=ilyevsky@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).