From: Eric Blake <eblake@redhat.com>
To: Richa Marwaha <rmarwah@linux.vnet.ibm.com>
Cc: coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Removing O_LARGEFILE from block layer
Date: Fri, 28 Sep 2012 14:22:29 -0600 [thread overview]
Message-ID: <50660705.7040608@redhat.com> (raw)
In-Reply-To: <1348850735-21903-1-git-send-email-rmarwah@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 672 bytes --]
On 09/28/2012 10:45 AM, Richa Marwaha wrote:
> QEMU by default configures -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> so there is not need to mention O_LARGEFILE in the block layer.
>
> Signed-off-by: Richa Marwaha <rmarwah@linux.vnet.ibm.com>
> ---
> block/raw-posix.c | 2 +-
> block/vdi.c | 2 +-
> block/vmdk.c | 6 +++---
> block/vvfat.c | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
Yay - I've previously suggested this, so it's nice to see it fixed.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
prev parent reply other threads:[~2012-09-28 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 16:45 [Qemu-devel] [PATCH] Removing O_LARGEFILE from block layer Richa Marwaha
2012-09-28 20:22 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50660705.7040608@redhat.com \
--to=eblake@redhat.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rmarwah@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).