* [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
@ 2012-10-01 18:41 Anthony Liguori
2012-10-01 18:49 ` Alex Williamson
2012-10-01 19:27 ` Anthony Liguori
0 siblings, 2 replies; 6+ messages in thread
From: Anthony Liguori @ 2012-10-01 18:41 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Alex Barcelo, Alex Williamson
We cannot cast directly from pointer to uint64.
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Alex Barcelo <abarcelo@ac.upc.edu>
Reported-by: Alex Barcelo <abarcelo@ac.upc.edu>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
hw/vfio_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
index a24558a..a1eeced 100644
--- a/hw/vfio_pci.c
+++ b/hw/vfio_pci.c
@@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
struct vfio_iommu_type1_dma_map map = {
.argsz = sizeof(map),
.flags = VFIO_DMA_MAP_FLAG_READ,
- .vaddr = (__u64)vaddr,
+ .vaddr = (__u64)(intptr_t)vaddr,
.iova = iova,
.size = size,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
2012-10-01 18:41 [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems Anthony Liguori
@ 2012-10-01 18:49 ` Alex Williamson
2012-10-02 6:11 ` Paolo Bonzini
2012-10-01 19:27 ` Anthony Liguori
1 sibling, 1 reply; 6+ messages in thread
From: Alex Williamson @ 2012-10-01 18:49 UTC (permalink / raw)
To: Anthony Liguori; +Cc: Alex Barcelo, qemu-devel
On Mon, 2012-10-01 at 13:41 -0500, Anthony Liguori wrote:
> We cannot cast directly from pointer to uint64.
>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Alex Barcelo <abarcelo@ac.upc.edu>
> Reported-by: Alex Barcelo <abarcelo@ac.upc.edu>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> hw/vfio_pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
> index a24558a..a1eeced 100644
> --- a/hw/vfio_pci.c
> +++ b/hw/vfio_pci.c
> @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
> struct vfio_iommu_type1_dma_map map = {
> .argsz = sizeof(map),
> .flags = VFIO_DMA_MAP_FLAG_READ,
> - .vaddr = (__u64)vaddr,
> + .vaddr = (__u64)(intptr_t)vaddr,
> .iova = iova,
> .size = size,
> };
Thanks Anthony
Acked-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
2012-10-01 18:49 ` Alex Williamson
@ 2012-10-02 6:11 ` Paolo Bonzini
2012-10-02 14:37 ` Alex Williamson
2012-10-02 15:03 ` Anthony Liguori
0 siblings, 2 replies; 6+ messages in thread
From: Paolo Bonzini @ 2012-10-02 6:11 UTC (permalink / raw)
To: Alex Williamson; +Cc: Anthony Liguori, Alex Barcelo, qemu-devel
Il 01/10/2012 20:49, Alex Williamson ha scritto:
>> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
>> > struct vfio_iommu_type1_dma_map map = {
>> > .argsz = sizeof(map),
>> > .flags = VFIO_DMA_MAP_FLAG_READ,
>> > - .vaddr = (__u64)vaddr,
>> > + .vaddr = (__u64)(intptr_t)vaddr,
Does this need to be uintptr_t?
Paolo
>> > .iova = iova,
>> > .size = size,
>> > };
> Thanks Anthony
>
> Acked-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
2012-10-02 6:11 ` Paolo Bonzini
@ 2012-10-02 14:37 ` Alex Williamson
2012-10-02 15:03 ` Anthony Liguori
1 sibling, 0 replies; 6+ messages in thread
From: Alex Williamson @ 2012-10-02 14:37 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Anthony Liguori, Alex Barcelo, qemu-devel
On Tue, 2012-10-02 at 08:11 +0200, Paolo Bonzini wrote:
> Il 01/10/2012 20:49, Alex Williamson ha scritto:
> >> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
> >> > struct vfio_iommu_type1_dma_map map = {
> >> > .argsz = sizeof(map),
> >> > .flags = VFIO_DMA_MAP_FLAG_READ,
> >> > - .vaddr = (__u64)vaddr,
> >> > + .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?
With a simple test program, I don't seem to get sign extension either
way. Logically uintptr_t seems preferable to me. I'll add a patch to
my tree. Thanks,
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
2012-10-02 6:11 ` Paolo Bonzini
2012-10-02 14:37 ` Alex Williamson
@ 2012-10-02 15:03 ` Anthony Liguori
1 sibling, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2012-10-02 15:03 UTC (permalink / raw)
To: Paolo Bonzini, Alex Williamson; +Cc: Alex Barcelo, qemu-devel
Paolo Bonzini <pbonzini@redhat.com> writes:
> Il 01/10/2012 20:49, Alex Williamson ha scritto:
>>> > @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
>>> > struct vfio_iommu_type1_dma_map map = {
>>> > .argsz = sizeof(map),
>>> > .flags = VFIO_DMA_MAP_FLAG_READ,
>>> > - .vaddr = (__u64)vaddr,
>>> > + .vaddr = (__u64)(intptr_t)vaddr,
>
> Does this need to be uintptr_t?
I don't think it matters semantically but using uintptr_t can't hurt.
Regards,
Anthony Liguori
>
> Paolo
>
>>> > .iova = iova,
>>> > .size = size,
>>> > };
>> Thanks Anthony
>>
>> Acked-by: Alex Williamson <alex.williamson@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems
2012-10-01 18:41 [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems Anthony Liguori
2012-10-01 18:49 ` Alex Williamson
@ 2012-10-01 19:27 ` Anthony Liguori
1 sibling, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2012-10-01 19:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Williamson, Alex Barcelo
Anthony Liguori <aliguori@us.ibm.com> writes:
> We cannot cast directly from pointer to uint64.
>
> Cc: Alex Williamson <alex.williamson@redhat.com>
> Cc: Alex Barcelo <abarcelo@ac.upc.edu>
> Reported-by: Alex Barcelo <abarcelo@ac.upc.edu>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Applied.
Regards,
Anthony Liguori
> ---
> hw/vfio_pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c
> index a24558a..a1eeced 100644
> --- a/hw/vfio_pci.c
> +++ b/hw/vfio_pci.c
> @@ -768,7 +768,7 @@ static int vfio_dma_map(VFIOContainer *container, target_phys_addr_t iova,
> struct vfio_iommu_type1_dma_map map = {
> .argsz = sizeof(map),
> .flags = VFIO_DMA_MAP_FLAG_READ,
> - .vaddr = (__u64)vaddr,
> + .vaddr = (__u64)(intptr_t)vaddr,
> .iova = iova,
> .size = size,
> };
> --
> 1.7.5.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-02 15:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-01 18:41 [Qemu-devel] [PATCH] vfio_pci: fix build on 32-bit systems Anthony Liguori
2012-10-01 18:49 ` Alex Williamson
2012-10-02 6:11 ` Paolo Bonzini
2012-10-02 14:37 ` Alex Williamson
2012-10-02 15:03 ` Anthony Liguori
2012-10-01 19:27 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).