From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34330) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIyLX-0001NF-2K for qemu-devel@nongnu.org; Tue, 02 Oct 2012 05:00:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIyLM-0005OT-1N for qemu-devel@nongnu.org; Tue, 02 Oct 2012 05:00:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIyLL-0005L1-Om for qemu-devel@nongnu.org; Tue, 02 Oct 2012 05:00:43 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9290Qwk000671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Oct 2012 05:00:38 -0400 Message-ID: <506AAD22.5040305@redhat.com> Date: Tue, 02 Oct 2012 11:00:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com> <1349103144-6827-3-git-send-email-pbonzini@redhat.com> <506A2D98.4080300@redhat.com> In-Reply-To: <506A2D98.4080300@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Il 02/10/2012 01:56, Eric Blake ha scritto: > On 10/01/2012 08:52 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> qapi-schema.json | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file modificato, 53 inserzioni(+) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 191d921..b443a99 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -2367,6 +2367,59 @@ >> 'opts': 'NetClientOptions' } } >> >> ## >> +# @IPSocketAddress >> +# >> +# Captures a range of possible destination addresses for an IP socket >> +# >> +# @host: host part of the address >> +# >> +# @port: port part of the address, or lowest port if @to is present >> +# >> +# @to: highest port to try >> +# >> +# @ipv4: whether to accept IPv4 addresses, default try both IPv4 and IPv6 >> +# #optional >> +# >> +# @ipv6: whether to accept IPv6 addresses, default try both IPv4 and IPv6 >> +# #optional >> +# >> +# Since 1.3 >> +## >> +{ 'type': 'IPSocketAddress', >> + 'data': { >> + 'host': 'str', >> + 'port': 'str', >> + '*to': 'uint16', > > I still think it's a bit weird to have: > > 'host':'localhost', 'port':'1000', 'to':1001 > > for a port range, all because of the possibility of named ports; should > '*to' be a 'str' if only for symmetry in the output? But it's > bike-shedding, so I'll live with whatever works (that is, I'm not > requesting a v3 on this patch). Would it be better if I changed 'to' to 'count'? >> +## >> +# @SocketAddress >> +# >> +# Captures the address of a socket, which could also be a named file descriptor >> +# >> +# Since 1.3 >> +## >> +{ 'union': 'SocketAddress', >> + 'data': { >> + 'inet': 'IPSocketAddress', >> + 'unix': 'UnixSocketAddress', >> + 'fd': 'String' } } > > I guess you had to use the String wrapper instead of 'str'; but a bit of > reading in the file showed that this part is at least correct. It's not absolutely necessary, but I preferred it that way. Paolo