From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43540)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJ06y-0005lx-Ff
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:54:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJ06u-0001qi-H0
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:54:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65296)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJ06u-0001qe-8N
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 06:53:56 -0400
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92Art7N031743
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 06:53:55 -0400
Message-ID: <506AC7BD.7080602@redhat.com>
Date: Tue, 02 Oct 2012 12:53:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1348217255-22441-1-git-send-email-quintela@redhat.com>
	<1348217255-22441-3-git-send-email-quintela@redhat.com>
	<505C5AD0.1080903@redhat.com> <50616F38.1000201@redhat.com>
	<87ipat9ms0.fsf@elfo.mitica>
In-Reply-To: <87ipat9ms0.fsf@elfo.mitica>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 02/41] fix migration sync
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Il 02/10/2012 12:43, Juan Quintela ha scritto:
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 21/09/2012 14:17, Paolo Bonzini ha scritto:
>>>
>>> -    QLIST_FOREACH(block, &ram_list.blocks, next) {
>>> -        for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) {
>>> -            if (!memory_region_get_dirty(block->mr, addr, TARGET_PAGE_SIZE,
>>> -                                         DIRTY_MEMORY_MIGRATION)) {
>>> -                memory_region_set_dirty(block->mr, addr, TARGET_PAGE_SIZE);
>>> -            }
>>> -        }
>>> -    }
>>> -
>>>      memory_global_dirty_log_start();
>>> +    memory_global_sync_dirty_bitmap(get_system_memory());
> 
> With the part of moving it after the memory_global_dirty_log_start() I
> agree.
> 
> With the other suggestion, I will take another look at it.  The problem
> is that vga code can also sync the kvm bitmap, and we want to get that
> notifications also.

I think I had replied to myself later... in any case, nothing that
cannot be improved after merging.  Thanks!

Paolo