From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35441) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ0ei-0003s3-2w for qemu-devel@nongnu.org; Tue, 02 Oct 2012 07:28:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ0eY-0005qK-Dq for qemu-devel@nongnu.org; Tue, 02 Oct 2012 07:28:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ0eY-0005qE-4J for qemu-devel@nongnu.org; Tue, 02 Oct 2012 07:28:42 -0400 Message-ID: <506ACFDB.3040302@redhat.com> Date: Tue, 02 Oct 2012 05:28:27 -0600 From: Eric Blake MIME-Version: 1.0 References: <1348691578-17231-1-git-send-email-imammedo@redhat.com> <1348691578-17231-19-git-send-email-imammedo@redhat.com> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig50614914D07FE8A2B92F169D" Subject: Re: [Qemu-devel] [PATCH 18/22] target-i386: parse cpu_model string into set of stringified properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: aliguori@us.ibm.com, ehabkost@redhat.com, jan.kiszka@siemens.com, Don@cloudswitch.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, pbonzini@redhat.com, Igor Mammedov , lersek@redhat.com, afaerber@suse.de, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig50614914D07FE8A2B92F169D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/30/2012 06:16 AM, Blue Swirl wrote: > On Wed, Sep 26, 2012 at 8:32 PM, Igor Mammedov wr= ote: >> cpu_model string does represent features in following format: >> ([+-]feat)|(feat=3Dfoo)|(feat) >> which makes it impossible directly use property infrastructure >> to set features on CPU. >> This patch introduces parser that splits CPU name from cpu_model and >> converts legacy features string into canonized set of strings that >> is compatible with property manipulation infrastructure. >> >> + >> + *cpu_name =3D strtok_r(s, ",", &sptr); >=20 > This would break build since strtok_r() isn't available on Mingw, it's Correct. Microsoft is stuck in the past when it comes to standard conformance. > not Posix either. Huh? http://pubs.opengroup.org/onlinepubs/9699919799/functions/strtok_r.h= tml strtok_r has been part of POSIX since pthreads were added. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig50614914D07FE8A2B92F169D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQas/bAAoJEKeha0olJ0NqhrwIAIfRQbBg7cm7K9VDPdZJ8UmK RTm+Op4wpyjW+CcMxT1XhhMOIUxJwAPD3GbVKtd/aYVBJBYJG98ikPFgmhV8RbpL lRXddqpvDKgqr92xfDol+o3FpYJ0aUXjMBgTFqPnXGVIvnDTSq+tAQHXO470Oxs2 ryiRht2RbN+zTOsB7Yjo89HyRjsVy4J5d77rB5W42yMBK5wKBgtO7Ir/fF+3DtsA kIRj8473xhQ7tBoNfxAn/NV0xuF1GBCpu+sxwMpcd2oNZGefT9+cZcEE4pUXBCP1 LlmmEiiYyiu54eac/2rRqwlPYJk0TU11wpWAYUvH00uKsVhmWxHhpoLuQwwJOtQ= =o3/y -----END PGP SIGNATURE----- --------------enig50614914D07FE8A2B92F169D--