From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ0pW-0005ux-AF for qemu-devel@nongnu.org; Tue, 02 Oct 2012 07:40:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ0pP-0001c2-Au for qemu-devel@nongnu.org; Tue, 02 Oct 2012 07:40:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ0pP-0001bM-2O for qemu-devel@nongnu.org; Tue, 02 Oct 2012 07:39:55 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92BdsY1015073 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Oct 2012 07:39:54 -0400 Message-ID: <506AD288.7010204@redhat.com> Date: Tue, 02 Oct 2012 05:39:52 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com> <1349103144-6827-3-git-send-email-pbonzini@redhat.com> <506A2D98.4080300@redhat.com> <506AAD22.5040305@redhat.com> In-Reply-To: <506AAD22.5040305@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigD28836C74AFDCB1D128696FB" Subject: Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD28836C74AFDCB1D128696FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/02/2012 03:00 AM, Paolo Bonzini wrote: > Il 02/10/2012 01:56, Eric Blake ha scritto: >> On 10/01/2012 08:52 AM, Paolo Bonzini wrote: >>> Signed-off-by: Paolo Bonzini >>> --- >>> +# >>> +# @port: port part of the address, or lowest port if @to is present >>> +# >>> +# @to: highest port to try >>> +# >>> +{ 'type': 'IPSocketAddress', >>> + 'data': { >>> + 'host': 'str', >>> + 'port': 'str', >>> + '*to': 'uint16', >> >> I still think it's a bit weird to have: >> >> 'host':'localhost', 'port':'1000', 'to':1001 >> >> for a port range, all because of the possibility of named ports; shoul= d >> '*to' be a 'str' if only for symmetry in the output? But it's >> bike-shedding, so I'll live with whatever works (that is, I'm not >> requesting a v3 on this patch). >=20 > Would it be better if I changed 'to' to 'count'? That does look a little better: 'host':'localhost', 'port':'1000', 'count':2 for the 2-port range 1000-1001. But it's all the same information, so I'm not strongly tied to any particular representation, as long as libvirt can parse it when querying and produce it when starting NBD. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigD28836C74AFDCB1D128696FB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQatKJAAoJEKeha0olJ0NqTIgIAJGEO6vmYdknx9VIzk9mkXCD +aviq+Qzp+rILIhfOtW8VqV6TvwMC0H/UykJ2ByCJprr1KFkTXHeonKh3IM8V0ok 9Ug3H2Srthh0WjybonheR/fVHDC5Hunayma/uXZ9oazZ40nzGPBjtw0EozHJA+h6 mcnAh95tBdQG95Qcs61sXmP1jni8Y9pBJfDd9RM/IPuM2fnToXBOZpxEo12h/DSV 5YXHQ7FP4Kh7lu48Fmge7TJXEX2oOKha0on39QF/Kw171Ni+HM8MmtUwnhr4L5ZL K+xxxuG4l9lY74MoTtcqXi5b+qXgjDT/WYY3PSwz0X7Omll3arCPO4AOWvjx3lI= =D6Cl -----END PGP SIGNATURE----- --------------enigD28836C74AFDCB1D128696FB--