From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ1qc-0001El-5Y for qemu-devel@nongnu.org; Tue, 02 Oct 2012 08:45:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ1qU-0000Jc-7N for qemu-devel@nongnu.org; Tue, 02 Oct 2012 08:45:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ1qT-0000IE-Vo for qemu-devel@nongnu.org; Tue, 02 Oct 2012 08:45:06 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92Cj4Qc006357 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 2 Oct 2012 08:45:05 -0400 Message-ID: <506AE1CF.3020305@redhat.com> Date: Tue, 02 Oct 2012 06:45:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349177616-5341-1-git-send-email-quintela@redhat.com> <1349177616-5341-5-git-send-email-quintela@redhat.com> In-Reply-To: <1349177616-5341-5-git-send-email-quintela@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig3CA6DA66E1FADDE1E5DDD5B1" Subject: Re: [Qemu-devel] [PATCH 04/41] migration: print total downtime for final phase of migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig3CA6DA66E1FADDE1E5DDD5B1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/02/2012 05:32 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela >=20 > Reviewed-by: Paolo Bonzini > Reviewed-by: Orit Wasserman > --- > +++ b/qmp-commands.hx > @@ -2267,6 +2267,8 @@ The main json-object contains the following: > - "total-time": total amount of ms since migration started. If > migration has ended, it returns the total migration > time (json-int) > +- "downtime": only present when migration has finished correctly > + total amount in ms for downtime that happened (json-in= t) I think the convention is to indent the second line to the same column as the first character after the colon. But unless it affects the appearance of any actual generated documentation, I don't think it's worth a respin for two fewer spaces. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig3CA6DA66E1FADDE1E5DDD5B1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQauHPAAoJEKeha0olJ0NqdS8H/2bSOtx4VNSMqvBNeLQA0C44 GRxwXtL8CnPiEmU++vZTTGWflMuQ8dmJWMdcGDvagXLfg4DJO6UtyhBunr41SjTM 7OT4YQ9XHGk7DCPvXVOboUxXhAFcym+CFX0i0QcuWW0cjFPxB/oeeQY5hAVbKlvI E7QxrOODGnR3W42zaJIq/PoShhzSRYqJUy/d9ECNJhK7LJeExQPDLmzChS4ilDme 9Wnw9jyogq1oRRIcaaNq3WOaEd3dgELBHJttVLJMYx3gALnXmfHc9Y30oRfZJn/y ewQG3NXIsDIYGPggKVCuDMFkf5DV0xKpIQAYWMrA6ytqlh5wHQa/VnKTtEvVqwY= =Ocwl -----END PGP SIGNATURE----- --------------enig3CA6DA66E1FADDE1E5DDD5B1--