From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types
Date: Tue, 02 Oct 2012 16:24:48 +0200 [thread overview]
Message-ID: <506AF930.7000902@redhat.com> (raw)
In-Reply-To: <20121002092727.1a1cf31d@doriath.home>
Il 02/10/2012 14:27, Luiz Capitulino ha scritto:
>>>> > >> for a port range, all because of the possibility of named ports; should
>>>> > >> '*to' be a 'str' if only for symmetry in the output? But it's
>>>> > >> bike-shedding, so I'll live with whatever works (that is, I'm not
>>>> > >> requesting a v3 on this patch).
>>> > >
>>> > > Would it be better if I changed 'to' to 'count'?
>> >
>> > That does look a little better:
>> >
>> > 'host':'localhost', 'port':'1000', 'count':2
>> >
>> > for the 2-port range 1000-1001. But it's all the same information, so
>> > I'm not strongly tied to any particular representation, as long as
>> > libvirt can parse it when querying and produce it when starting NBD.
> Wouldn't it be cleaner to pass a list of port numbers? We could have:
>
> *port-list: [ 'int' ]
> *service: 'str'
A list of ports doesn't work too well for say 5900-5999. I think the
port + count is the simplest.
Paolo
next prev parent reply other threads:[~2012-10-02 14:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-01 14:52 [Qemu-devel] [PATCH v2 0/9] Embedded NBD server Paolo Bonzini
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 1/9] build: add QAPI files to the tools Paolo Bonzini
2012-10-02 12:31 ` Luiz Capitulino
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types Paolo Bonzini
2012-10-01 23:56 ` Eric Blake
2012-10-02 9:00 ` Paolo Bonzini
2012-10-02 11:39 ` Eric Blake
2012-10-02 12:27 ` Luiz Capitulino
2012-10-02 14:24 ` Paolo Bonzini [this message]
2012-10-02 15:27 ` Luiz Capitulino
2012-10-02 15:31 ` Paolo Bonzini
2012-10-02 12:32 ` Luiz Capitulino
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 3/9] qemu-sockets: add error propagation to inet_parse Paolo Bonzini
2012-10-02 12:34 ` Luiz Capitulino
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 4/9] qemu-sockets: add error propagation to Unix socket functions Paolo Bonzini
2012-10-01 17:17 ` Luiz Capitulino
2012-10-01 19:07 ` Paolo Bonzini
2012-10-01 23:05 ` Luiz Capitulino
2012-10-02 6:09 ` Paolo Bonzini
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 5/9] qemu-sockets: return IPSocketAddress from inet_parse Paolo Bonzini
2012-10-02 12:36 ` Luiz Capitulino
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 6/9] qemu-sockets: add socket_listen, socket_connect, socket_parse Paolo Bonzini
2012-10-02 12:37 ` Luiz Capitulino
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 7/9] block: add close notifiers Paolo Bonzini
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 8/9] qmp: add NBD server commands Paolo Bonzini
2012-10-02 2:50 ` Eric Blake
2012-10-02 12:37 ` Luiz Capitulino
2012-10-31 11:23 ` Christoph Hellwig
2012-10-31 12:46 ` Paolo Bonzini
2012-10-31 13:01 ` Christoph Hellwig
2012-10-01 14:52 ` [Qemu-devel] [PATCH v2 9/9] hmp: " Paolo Bonzini
2012-10-02 12:38 ` Luiz Capitulino
2012-10-01 18:08 ` [Qemu-devel] [PATCH v2 0/9] Embedded NBD server Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506AF930.7000902@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).