From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34492)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJ4RD-0003CA-P2
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:31:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJ4R6-00056m-0J
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:31:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48112)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJ4R5-00056g-Ng
	for qemu-devel@nongnu.org; Tue, 02 Oct 2012 11:31:03 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q92FV2j8012162
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 2 Oct 2012 11:31:03 -0400
Message-ID: <506B08B4.3070709@redhat.com>
Date: Tue, 02 Oct 2012 17:31:00 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349103144-6827-1-git-send-email-pbonzini@redhat.com>
	<1349103144-6827-3-git-send-email-pbonzini@redhat.com>
	<506A2D98.4080300@redhat.com> <506AAD22.5040305@redhat.com>
	<506AD288.7010204@redhat.com>
	<20121002092727.1a1cf31d@doriath.home>
	<506AF930.7000902@redhat.com>
	<20121002122758.12074163@doriath.home>
In-Reply-To: <20121002122758.12074163@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/9] qapi: add socket address types
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org

Il 02/10/2012 17:27, Luiz Capitulino ha scritto:
>>> > > Wouldn't it be cleaner to pass a list of port numbers? We could have:
>>> > > 
>>> > >  *port-list: [ 'int' ]
>>> > >  *service: 'str'
>> > 
>> > A list of ports doesn't work too well for say 5900-5999.  I think the
>> > port + count is the simplest.
> True, but consider making it a union then, so that we can have service
> as a string and port as an integer.

But then how would you name the containing union?

In the end this is a hack for VNC or little more... any change will
propagate all over the place due to QemuOpts and qemu-char using "to".
It is an optional argument, I don't think it's worth much time. :)

Paolo