From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ59Z-0006mY-0D for qemu-devel@nongnu.org; Tue, 02 Oct 2012 12:17:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ59S-0006RB-DU for qemu-devel@nongnu.org; Tue, 02 Oct 2012 12:17:00 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:19577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ59S-0006R4-8l for qemu-devel@nongnu.org; Tue, 02 Oct 2012 12:16:54 -0400 Message-ID: <506B134B.20006@citrix.com> Date: Tue, 2 Oct 2012 17:16:11 +0100 From: Anthony PERARD MIME-Version: 1.0 References: <1348744360-2989-1-git-send-email-anthony.perard@citrix.com> <1348744360-2989-5-git-send-email-anthony.perard@citrix.com> <506AC11F.1030402@redhat.com> In-Reply-To: <506AC11F.1030402@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Xen Devel , QEMU-devel , Stefano Stabellini On 10/02/2012 11:25 AM, Avi Kivity wrote: > On 10/01/2012 12:36 PM, Stefano Stabellini wrote: >> On Thu, 27 Sep 2012, Anthony PERARD wrote: >>> This patch add some calls to xen_modified_memory to notify Xen about dirtybits >>> during migration. >>> >>> Signed-off-by: Anthony PERARD >> >> If I am not mistaken, this is the last patch that needs reviewing. >> Avi, are you OK with it? >> >> >> >>> exec.c | 1 + >>> memory.c | 2 ++ >>> 2 files changed, 3 insertions(+) >>> >>> diff --git a/exec.c b/exec.c >>> index 366684c..1114a09 100644 >>> --- a/exec.c >>> +++ b/exec.c >>> @@ -3427,6 +3427,7 @@ static void invalidate_and_set_dirty(target_phys_addr_t addr, >>> /* set dirty bit */ >>> cpu_physical_memory_set_dirty_flags(addr, (0xff & ~CODE_DIRTY_FLAG)); >>> } >>> + xen_modified_memory(addr, length); >>> } >>> >>> void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf, >>> diff --git a/memory.c b/memory.c >>> index 4f3ade0..015c544 100644 >>> --- a/memory.c >>> +++ b/memory.c >>> @@ -19,6 +19,7 @@ >>> #include "bitops.h" >>> #include "kvm.h" >>> #include >>> +#include "hw/xen.h" >>> >>> #define WANT_EXEC_OBSOLETE >>> #include "exec-obsolete.h" >>> @@ -1077,6 +1078,7 @@ void memory_region_set_dirty(MemoryRegion *mr, target_phys_addr_t addr, >>> target_phys_addr_t size) >>> { >>> assert(mr->terminates); >>> + xen_modified_memory(mr->ram_addr + addr, size); >>> return cpu_physical_memory_set_dirty_range(mr->ram_addr + addr, size, -1); >>> } > > I would prefer this bit pushed into cpu_physical_set_dirty_range(). Ok, I will call the function from cpu_physical_memory_set_dirty_range() instead of from memory_region_set_dirty. > Possibly the first bit too? But the call from invalidate_and_set_dirty, I can not remove it because it does not work. The xen function must be called without condition as xen and qemu does not maintained the same dirtymap. -- Anthony PERARD