qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xen.org>,
	QEMU-devel <qemu-devel@nongnu.org>,
	Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory.
Date: Tue, 02 Oct 2012 18:20:45 +0200	[thread overview]
Message-ID: <506B145D.4030505@redhat.com> (raw)
In-Reply-To: <506B134B.20006@citrix.com>

On 10/02/2012 06:16 PM, Anthony PERARD wrote:
> 
>> Possibly the first bit too?
> 
> But the call from invalidate_and_set_dirty, I can not remove it because
> it does not work.  The xen function must be called without condition as
> xen and qemu does not maintained the same dirtymap.

Right, in fact we added invalidate_and_set_dirty() in order to stick the
xen call in it, I just forgot about it.  So the first bit is okay.


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-10-02 16:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-27 11:12 [Qemu-devel] [PATCH V4 0/5] Xen, introducing dirty log for migration Anthony PERARD
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 1/5] QMP, Introduce xen-set-global-dirty-log command Anthony PERARD
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 2/5] xen: Introduce xen_modified_memory Anthony PERARD
2012-10-01 10:32   ` Stefano Stabellini
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 3/5] exec: Introduce helper to set dirty flags Anthony PERARD
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory Anthony PERARD
2012-10-01 10:36   ` Stefano Stabellini
2012-10-02 10:25     ` Avi Kivity
2012-10-02 16:16       ` Anthony PERARD
2012-10-02 16:20         ` Avi Kivity [this message]
2012-09-27 11:12 ` [Qemu-devel] [PATCH V4 5/5] xen: Set the vram dirty when an error occur Anthony PERARD
2012-10-01 10:33   ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506B145D.4030505@redhat.com \
    --to=avi@redhat.com \
    --cc=Stefano.Stabellini@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).