From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60114) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ5DQ-0000Mm-1b for qemu-devel@nongnu.org; Tue, 02 Oct 2012 12:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJ5DK-0008Ba-94 for qemu-devel@nongnu.org; Tue, 02 Oct 2012 12:20:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJ5DK-0008BM-0q for qemu-devel@nongnu.org; Tue, 02 Oct 2012 12:20:54 -0400 Message-ID: <506B145D.4030505@redhat.com> Date: Tue, 02 Oct 2012 18:20:45 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1348744360-2989-1-git-send-email-anthony.perard@citrix.com> <1348744360-2989-5-git-send-email-anthony.perard@citrix.com> <506AC11F.1030402@redhat.com> <506B134B.20006@citrix.com> In-Reply-To: <506B134B.20006@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 4/5] exec, memory: Call to xen_modified_memory. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: Xen Devel , QEMU-devel , Stefano Stabellini On 10/02/2012 06:16 PM, Anthony PERARD wrote: > >> Possibly the first bit too? > > But the call from invalidate_and_set_dirty, I can not remove it because > it does not work. The xen function must be called without condition as > xen and qemu does not maintained the same dirtymap. Right, in fact we added invalidate_and_set_dirty() in order to stick the xen call in it, I just forgot about it. So the first bit is okay. -- error compiling committee.c: too many arguments to function