From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39950)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiaxia347os@163.com>) id 1TJNtm-0008MK-03
	for qemu-devel@nongnu.org; Wed, 03 Oct 2012 08:18:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiaxia347os@163.com>) id 1TJNth-0000wN-AT
	for qemu-devel@nongnu.org; Wed, 03 Oct 2012 08:17:57 -0400
Received: from m12-11.163.com ([220.181.12.11]:52984)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiaxia347os@163.com>) id 1TJNtf-0000vI-TF
	for qemu-devel@nongnu.org; Wed, 03 Oct 2012 08:17:53 -0400
Message-ID: <506C2206.7030809@163.com>
Date: Wed, 03 Oct 2012 19:31:18 +0800
From: wenchao xia <xiaxia347os@163.com>
MIME-Version: 1.0
References: <1348906418-16471-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1348906418-16471-6-git-send-email-xiawenc@linux.vnet.ibm.com>
In-Reply-To: <1348906418-16471-6-git-send-email-xiawenc@linux.vnet.ibm.com>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com, eblake@redhat.com

>> +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info)
>> +{
>> +    return info->member_addr->virt_size;
>
>Please change this to:
>
>     QBlockStaticInfoAddr addrs;
>     qb_setup_info_addr(info, &addrs);
>     return *addrs->virt_size;
>
>and similarly for the others.
>
>QBlockStaticInfoAddr should not be a public struct.  I'm sorry if this
>wasn't clear.
>
>I'll review the rest on Monday.
>
>Paolo
>
  Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see
what it really is. It is actually defined in internal header files.