[Qemu-devel] [PATCH] hw: Add missing 'static' attribute for QEMUMachine

[Qemu-devel] [PATCH] hw: Add missing 'static' attribute for QEMUMachine

[Stefan Weil]

It was missing for leon3 and mips_fulong2e.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 hw/leon3.c              |    2 +-
 hw/mips/mips_fulong2e.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/leon3.c b/hw/leon3.c
index 878d3aa..7a9729d 100644
--- a/hw/leon3.c
+++ b/hw/leon3.c
@@ -210,7 +210,7 @@ static void leon3_generic_hw_init(ram_addr_t  ram_size,
     }
 }
 
-QEMUMachine leon3_generic_machine = {
+static QEMUMachine leon3_generic_machine = {
     .name     = "leon3_generic",
     .desc     = "Leon-3 generic",
     .init     = leon3_generic_hw_init,
diff --git a/hw/mips/mips_fulong2e.c b/hw/mips/mips_fulong2e.c
index 38e4b86..d4a8672 100644
--- a/hw/mips/mips_fulong2e.c
+++ b/hw/mips/mips_fulong2e.c
@@ -392,7 +392,7 @@ static void mips_fulong2e_init(ram_addr_t ram_size, const char *boot_device,
     network_init();
 }
 
-QEMUMachine mips_fulong2e_machine = {
+static QEMUMachine mips_fulong2e_machine = {
     .name = "fulong2e",
     .desc = "Fulong 2e mini pc",
     .init = mips_fulong2e_init,
-- 
1.7.10

Re: [Qemu-devel] [PATCH] hw: Add missing 'static' attribute for QEMUMachine

[Andreas Färber]

Am 03.10.2012 11:19, schrieb Stefan Weil:
> It was missing for leon3 and mips_fulong2e.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Reviewed-by: Andreas Färber <afaerber@suse.de>

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw: Add missing 'static' attribute for QEMUMachine

[Stefan Hajnoczi]

On Wed, Oct 03, 2012 at 11:19:39AM +0200, Stefan Weil wrote:
> It was missing for leon3 and mips_fulong2e.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  hw/leon3.c              |    2 +-
>  hw/mips/mips_fulong2e.c |    2 +-

This file doesn't exist in my tree (based on qemu.git/master
a14c74928ba1fdaada515717f4d3c3fa3275d6f7).  I have modified it to
hw/mips_fulong2e.c.

>  2 files changed, 2 insertions(+), 2 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan