From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Igor Mammedov" <imammedo@redhat.com>,
qemu-devel@nongnu.org, "Gleb Natapov" <gleb@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC 02/18] pc: create PC object on pc_init1()
Date: Wed, 03 Oct 2012 16:54:22 +0200 [thread overview]
Message-ID: <506C519E.1070703@redhat.com> (raw)
In-Reply-To: <20121003145347.GR15784@otherpad.lan.raisama.net>
Il 03/10/2012 16:53, Eduardo Habkost ha scritto:
>> >
>> > Can you add a hook to QEMUMachine so that this object is created by
>> > qdev_get_machine() and ends up at /machine?
> Oh, I didn't know there was an existing "machine" object already, I
> didn't know qdev_get_machine().
>
> Shouldn't /machine be a child of the "container" class?
It should, but note that "container" is really just the same as
TYPE_OBJECT. It is only for clarity that a difference class is used.
So using TYPE_DEVICE for now is not too bad.
Paolo
> That leads to
> the other question you asked in another message: in this case, PC
> wouldn't be a child of DeviceState, and we would need an additional
> mechanism to allow non-DeviceState objects to use global properties.
>
> (The sole reason I introduced the PC class was to allow the PC code to
> use the compatibility "contiguous_apic_ids" global property.)
next prev parent reply other threads:[~2012-10-03 14:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 13:28 [Qemu-devel] [RFC v2 00/18] Fix APIC-ID-based CPU topology Eduardo Habkost
2012-10-03 13:28 ` [Qemu-devel] [RFC 01/18] pc: create "PC" device class Eduardo Habkost
2012-10-03 14:38 ` Paolo Bonzini
2012-10-03 14:48 ` Eduardo Habkost
2012-10-03 14:50 ` Paolo Bonzini
2012-10-04 13:46 ` Anthony Liguori
2012-10-04 13:50 ` Paolo Bonzini
2012-10-04 14:28 ` Anthony Liguori
2012-10-04 14:43 ` Eduardo Habkost
2012-10-04 15:10 ` Anthony Liguori
2012-10-04 16:03 ` Eduardo Habkost
2012-10-04 17:42 ` Anthony Liguori
2012-10-04 17:51 ` Eduardo Habkost
2012-10-04 16:00 ` Andreas Färber
2012-10-04 13:57 ` Eduardo Habkost
2012-10-04 14:29 ` Anthony Liguori
2012-10-04 15:57 ` Eduardo Habkost
2012-10-04 17:43 ` Anthony Liguori
2012-10-03 13:28 ` [Qemu-devel] [RFC 02/18] pc: create PC object on pc_init1() Eduardo Habkost
2012-10-03 14:40 ` Paolo Bonzini
2012-10-03 14:53 ` Eduardo Habkost
2012-10-03 14:54 ` Paolo Bonzini [this message]
2012-10-03 13:28 ` [Qemu-devel] [RFC 03/18] pc: add PC object argument to some init functions Eduardo Habkost
2012-10-04 11:56 ` Igor Mammedov
2012-10-03 13:29 ` [Qemu-devel] [RFC 04/18] move I/O-related definitions from qemu-common.h to a new header (qemu-stdio.h) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 05/18] cpus.h: include qemu-stdio.h Eduardo Habkost
2012-10-04 12:00 ` Igor Mammedov
2012-10-04 13:14 ` Eduardo Habkost
2012-10-04 14:05 ` Igor Mammedov
2012-10-03 13:29 ` [Qemu-devel] [RFC 06/18] hw/apic.c: rename bit functions to not conflict with bitops.h (v2) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 07/18] kvm: create kvm_arch_vcpu_id() function Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 08/18] target-i386: kvm: set vcpu_id to APIC ID instead of CPU index (v2) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 09/18] target-i386: cpu: move cpuid_apic_id initialization to cpu_x86_register() Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 10/18] target-i386: cpu: add apic_id argument " Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 11/18] target-i386: cpu_x86_init: allow APIC ID to be set by caller Eduardo Habkost
2012-10-04 12:47 ` Igor Mammedov
2012-10-03 13:29 ` [Qemu-devel] [RFC 12/18] fw_cfg: remove FW_CFG_MAX_CPUS from fw_cfg_init() Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 13/18] pc: set explicit APIC ID for CPUs Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 14/18] pc: create apic_id_for_cpu() function (v3) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 15/18] pc: set fw_cfg data based on APIC ID calculation (v2) Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 16/18] tests: support target-specific unit tests Eduardo Habkost
2012-10-03 13:29 ` [Qemu-devel] [RFC 17/18] target-i386: topology & APIC ID utility functions (v2) Eduardo Habkost
2012-10-03 20:11 ` Blue Swirl
2012-10-03 13:29 ` [Qemu-devel] [RFC 18/18] pc: generate APIC IDs according to CPU topology (v3) Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506C519E.1070703@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=gleb@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).