From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQlc-0006BG-G3 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 11:21:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJQlW-0000c2-J5 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 11:21:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQlW-0000bn-7i for qemu-devel@nongnu.org; Wed, 03 Oct 2012 11:21:38 -0400 Message-ID: <506C57CE.9060002@redhat.com> Date: Wed, 03 Oct 2012 17:20:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349192235-31895-8-git-send-email-imammedo@redhat.com> <20121002203845.GB4362@otherpad.lan.raisama.net> <20121003150339.GS15784@otherpad.lan.raisama.net> In-Reply-To: <20121003150339.GS15784@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features into properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: aliguori@us.ibm.com, akong@redhat.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, Don@cloudswitch.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, Igor Mammedov , hpa@linux.intel.com, lersek@redhat.com, afaerber@suse.de Il 03/10/2012 17:03, Eduardo Habkost ha scritto: > On Tue, Oct 02, 2012 at 05:38:45PM -0300, Eduardo Habkost wrote: >> (Now replying on the right thread, to keep the discussion in the right >> place. I don't know how I ended up replying to a pre-historic version of >> the patch, sorry.) >> >> On Tue, Oct 02, 2012 at 05:36:59PM +0200, Igor Mammedov wrote: >> [...] >>> @@ -1938,6 +2043,12 @@ static void x86_cpu_initfn(Object *obj) >>> object_property_add(obj, "tsc-frequency", "int", >>> x86_cpuid_get_tsc_freq, >>> x86_cpuid_set_tsc_freq, NULL, NULL, NULL); >>> + x86_register_cpuid_properties(obj, feature_name); >>> + x86_register_cpuid_properties(obj, ext_feature_name); >>> + x86_register_cpuid_properties(obj, ext2_feature_name); >>> + x86_register_cpuid_properties(obj, ext3_feature_name); >>> + x86_register_cpuid_properties(obj, kvm_feature_name); >>> + x86_register_cpuid_properties(obj, svm_feature_name); >> >> Stupid question about qdev: >> >> - qdev_prop_set_globals() is called from device_initfn() >> - device_initfn() is called before the child class instance_init() >> function (x86_cpu_initfn()) >> - So, qdev_prop_set_globals() gets called before the CPU class >> properties are registered. >> >> So this would defeat the whole point of all the work we're doing, that >> is to allow compatibility bits to be set as machine-type global >> properties. But I don't know what's the right solution here. >> >> Should the qdev_prop_set_globals() call be moved to qdev_init() instead? >> Should the CPU properties be registered somewhere else? Properties should be registered (for all objects, not just CPUs) in the instance_init function. This is device_initfn. I would add an instance_postinit function that is called at the end of object_initialize_with_type, that is after instance_init, and in the opposite order (i.e. from the leaf to the root). Paolo > Replying to myself: it wouldn't make sense to call it on qdev_init() as > it would overwrite properties set between the calls to object_new() and > qdev_init(). > > But I still don't see what would be the proper way to solve this. I > don't see any mechanism that would allow us to ensure the > object_property_add() calls are made before qdev_prop_set_globals() is > called. >