From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJTkG-0006c9-KP for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:32:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJTkB-000717-N4 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:32:32 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJTkB-00070U-FK for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:32:27 -0400 Received: by wibhq12 with SMTP id hq12so2088981wib.10 for ; Wed, 03 Oct 2012 11:32:26 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <506C84B5.8030006@redhat.com> Date: Wed, 03 Oct 2012 20:32:21 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349285059-5415-1-git-send-email-lcapitulino@redhat.com> <1349285059-5415-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1349285059-5415-3-git-send-email-lcapitulino@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org Il 03/10/2012 19:24, Luiz Capitulino ha scritto: > Defaults to /var/run. Please add instead --localstatedir (defaulting to ${prefix}/var), and make the guest agent's directory /run inside that one. Packagers already know to override --localstatedir=/var, in some cases macros even do it automatically. Paolo > Signed-off-by: Luiz Capitulino > --- > configure | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/configure b/configure > index 4cfcdc6..4f3d2ed 100755 > --- a/configure > +++ b/configure > @@ -215,6 +215,7 @@ usb_redir="" > opengl="" > zlib="yes" > qemuga="yes" > +qemuga_statedir="/var/run" > want_tools="yes" > libiscsi="" > coroutine="" > @@ -628,6 +629,8 @@ for opt do > ;; > --sysconfdir=*) sysconfdir="$optarg" > ;; > + --guest-agent-statedir=*) qemuga_statedir="$optarg" > + ;; > --sbindir=*|--sharedstatedir=*|--localstatedir=*|\ > --oldincludedir=*|--datarootdir=*|--infodir=*|--localedir=*|\ > --htmldir=*|--dvidir=*|--pdfdir=*|--psdir=*) > @@ -1022,6 +1025,7 @@ echo " --datadir=PATH install firmware in PATH$confsuffix" > echo " --docdir=PATH install documentation in PATH$confsuffix" > echo " --bindir=PATH install binaries in PATH" > echo " --sysconfdir=PATH install config in PATH$confsuffix" > +echo " --guest-agent-statedir=PATH set Guest Agent state directory to PATH" > echo " --with-confsuffix=SUFFIX suffix for QEMU data inside datadir and sysconfdir [$confsuffix]" > echo " --enable-debug-tcg enable TCG debugging" > echo " --disable-debug-tcg disable TCG debugging (default)" > @@ -3086,6 +3090,7 @@ echo "library directory `eval echo $libdir`" > echo "libexec directory `eval echo $libexecdir`" > echo "include directory `eval echo $includedir`" > echo "config directory `eval echo $sysconfdir`" > +echo "qemu-ga state directory $qemuga_statedir" > if test "$mingw32" = "no" ; then > echo "Manual directory `eval echo $mandir`" > echo "ELF interp prefix $interp_prefix" > @@ -3196,6 +3201,7 @@ echo "qemu_datadir=$qemu_datadir" >> $config_host_mak > echo "qemu_docdir=$qemu_docdir" >> $config_host_mak > echo "CONFIG_QEMU_HELPERDIR=\"$libexecdir\"" >> $config_host_mak > > +echo "CONFIG_QEMUGA_STATEDIR=\"$qemuga_statedir\"" >> $config_host_mak > echo "ARCH=$ARCH" >> $config_host_mak > if test "$debug_tcg" = "yes" ; then > echo "CONFIG_DEBUG_TCG=y" >> $config_host_mak >