From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJU7a-0008WL-Kn for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:56:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJU7Z-0007Rx-Jp for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:56:38 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:37446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJU7Z-0007Rs-9U for qemu-devel@nongnu.org; Wed, 03 Oct 2012 14:56:37 -0400 Received: by wgbdr1 with SMTP id dr1so4765909wgb.10 for ; Wed, 03 Oct 2012 11:56:36 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <506C8A5F.8060403@redhat.com> Date: Wed, 03 Oct 2012 20:56:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349285059-5415-1-git-send-email-lcapitulino@redhat.com> <1349285059-5415-3-git-send-email-lcapitulino@redhat.com> <506C84B5.8030006@redhat.com> <20121003155325.4cc3bce8@doriath.home> In-Reply-To: <20121003155325.4cc3bce8@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] configure: add --guest-agent-statedir List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org Il 03/10/2012 20:53, Luiz Capitulino ha scritto: > On Wed, 03 Oct 2012 20:32:21 +0200 > Paolo Bonzini wrote: > >> Il 03/10/2012 19:24, Luiz Capitulino ha scritto: >>> Defaults to /var/run. >> >> Please add instead --localstatedir (defaulting to ${prefix}/var), and >> make the guest agent's directory /run inside that one. Packagers >> already know to override --localstatedir=/var, in some cases macros even >> do it automatically. > > Well, that was my first version but I discarded it for two reasons. > > First, --localstatedir is a host-side setting but qemu-ga is not supposed to > run in the host. What if I want a different setting for guests? Then you should build twice, like you do when the guest is a completely different OS. > Second, having /run appended to --localstatedir (or whatever we choose) may > have a bad effect if qemu is built with --localstatedir=, where qemu-ga's > state will be "/run" (good for Fedora, but might not be good for other > distros or other unixes). I'm not sure I follow, it would be --localstatedir=/var usually. Even Fedora would not use --localstatedir=. Paolo > > I'm not strong about this though, it just was my reasoning while doing this. > >