From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46253)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJflO-0001UF-ST
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 03:22:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJflI-0007YL-QQ
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 03:22:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:62282)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TJflI-0007YB-Hi
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 03:22:24 -0400
Message-ID: <506D38D6.6010906@redhat.com>
Date: Thu, 04 Oct 2012 09:20:54 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349192235-31895-8-git-send-email-imammedo@redhat.com>
	<20121002203845.GB4362@otherpad.lan.raisama.net>
	<20121003150339.GS15784@otherpad.lan.raisama.net>
	<506C57CE.9060002@redhat.com>
	<20121003182411.7075c0ef@nial.usersys.redhat.com>
	<20121003165434.GT15784@otherpad.lan.raisama.net>
	<20121004085322.599a19ab@nial.usersys.redhat.com>
In-Reply-To: <20121004085322.599a19ab@nial.usersys.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/23] target-i386: convert cpuid features
 into properties
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: aliguori@us.ibm.com, akong@redhat.com, Eduardo Habkost <ehabkost@redhat.com>, gleb@redhat.com, jan.kiszka@siemens.com, Don@cloudswitch.com, mtosatti@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, hpa@linux.intel.com, lersek@redhat.com, afaerber@suse.de, stefanha@linux.vnet.ibm.com

Il 04/10/2012 08:53, Igor Mammedov ha scritto:
> IMHO from general POV it's not correct to set properties before object is
> completely created.
> But Anthony wants to keep qdev_prop_set_globals() qdev only thing, so could
> we move it from device_initfn() to qdev_init() or some other place then?

Yes, moving it qdev_init would work.  I don't like it particularly but
hey...

Paolo