From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJhys-0006Ge-Vv for qemu-devel@nongnu.org; Thu, 04 Oct 2012 05:44:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJhyo-0005td-19 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 05:44:34 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:42415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJhyn-0005tS-Qy for qemu-devel@nongnu.org; Thu, 04 Oct 2012 05:44:29 -0400 Received: by mail-pb0-f45.google.com with SMTP id rp2so419148pbb.4 for ; Thu, 04 Oct 2012 02:44:28 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <506D5A74.5040904@redhat.com> Date: Thu, 04 Oct 2012 11:44:20 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349287077-10062-1-git-send-email-sandmann@cs.au.dk> In-Reply-To: <1349287077-10062-1-git-send-email-sandmann@cs.au.dk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when spice-server is new enough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?U8O4cmVuIFNhbmRtYW5u?= Cc: =?UTF-8?B?U8O4cmVuIFNhbmRtYQ==?= =?UTF-8?B?bm4gUGVkZXJzZW4=?= , qemu-devel@nongnu.org, kraxel@redhat.com Il 03/10/2012 19:57, Søren Sandmann ha scritto: > From: Søren Sandmann Pedersen > > When spice-server is newer than 0.12.0, the default revision should be > QXL_REVISION_STABLE_V12. > > Signed-off-by: Soren Sandmann > --- > hw/qxl.h | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/hw/qxl.h b/hw/qxl.h > index 5553824..4460bb2 100644 > --- a/hw/qxl.h > +++ b/hw/qxl.h > @@ -129,8 +129,7 @@ typedef struct PCIQXLDevice { > } \ > } while (0) > > -#if 0 > -/* spice-server 0.12 is still in development */ > +#if SPICE_SERVER_VERSION >= 0x000c00 /* 0x000c00 == 0.12.0 */ > #define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V12 > #else > #define QXL_DEFAULT_REVISION QXL_REVISION_STABLE_V10 > No, that's not possible. The revision must be the same for all machines started with the same "-M" argument. So your only choice is to make 0.12 a requirement for QEMU 1.3. Then you can use compatibility properties (see the long list of strings in hw/pc_piix.c) to ensure that pc-1.2 and earlier machines use the previous revision. If you cannot release 0.12 in time for QEMU 1.3, your only choice is to wait for 1.4. In the meanwhile, use "-global qxl.revision=4 -global qxl-vga.revision=4" to create a machine with revision 4. Paolo