From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59200)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TJiUT-0006pC-Ds
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:17:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TJiUP-0000eh-Fp
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:17:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25359)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1TJiUP-0000dy-7j
	for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:17:09 -0400
Message-ID: <506D621E.8040506@redhat.com>
Date: Thu, 04 Oct 2012 12:17:02 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1349280245-16341-1-git-send-email-avi@redhat.com>
	<1349280245-16341-18-git-send-email-avi@redhat.com>
	<CAAu8pHsGnnVFYUgKaA2K15c8uKTOx-xuLx65q=sxuZx2=qyeXg@mail.gmail.com>
In-Reply-To: <CAAu8pHsGnnVFYUgKaA2K15c8uKTOx-xuLx65q=sxuZx2=qyeXg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v1 17/22] memory: use AddressSpace for
	MemoryListener filtering
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, liu ping fan <qemulist@gmail.com>

On 10/03/2012 10:16 PM, Blue Swirl wrote:
>> @@ -141,7 +141,7 @@ static bool memory_listener_match(MemoryListener *listener,
>>  #define MEMORY_LISTENER_UPDATE_REGION(fr, as, dir, callback)            \
>>      MEMORY_LISTENER_CALL(callback, dir, (&(MemoryRegionSection) {       \
>>          .mr = (fr)->mr,                                                 \
>> -        .address_space = (as)->root,                                    \
>> +        .address_space = (as),                                          \
> 
> Maybe remove parenthesis.

I prefer to keep it for consistency and defensiveness, unless you insist.


-- 
error compiling committee.c: too many arguments to function