From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJihO-0006y7-GY for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:30:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJihI-00058D-Or for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:30:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJihI-00057r-Fr for qemu-devel@nongnu.org; Thu, 04 Oct 2012 06:30:28 -0400 Message-ID: <506D653C.4040006@redhat.com> Date: Thu, 04 Oct 2012 12:30:20 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1349280245-16341-1-git-send-email-avi@redhat.com> <1349280245-16341-20-git-send-email-avi@redhat.com> <506D2EEE.3010904@redhat.com> <506D61C5.7070009@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v1 19/22] memory: per-AddressSpace dispatch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: "Michael S. Tsirkin" , liu ping fan , qemu-devel@nongnu.org, Blue Swirl , Anthony Liguori , Paolo Bonzini On 10/04/2012 12:29 PM, Peter Maydell wrote: > On 4 October 2012 11:15, Avi Kivity wrote: >> On 10/04/2012 10:47 AM, Peter Maydell wrote: >>> I'd favour just moving everything to 64 bits (the remaining >>> 32 bit targets are: cris, lm32, m68k, microblaze, or32, sh4, unicore32, >>> xtensa). However it does require some review of devices to check that >>> they're not using target_phys_addr_t when they meant uint32_t [eg >>> in registers for DMA devices] or relying on 32 bit wraparound. >> >> I posted a patch. I did no review, the cost/benefit tradeoff is >> horrible IMO, especially with me not knowing the details. If something >> breaks, git bisect will save the day. > > It might be nice to cc the maintainers of the affected target archs > and suggest that they at least do a quick smoke test :-) Yes, will do. -- error compiling committee.c: too many arguments to function