From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJmlI-0002hb-2i for qemu-devel@nongnu.org; Thu, 04 Oct 2012 10:50:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJmlC-0008Q7-2Y for qemu-devel@nongnu.org; Thu, 04 Oct 2012 10:50:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJmlB-0008NR-R0 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 10:50:46 -0400 Message-ID: <506DA239.60509@redhat.com> Date: Thu, 04 Oct 2012 08:50:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1323868833-541-1-git-send-email-mohan@in.ibm.com> <1323868833-541-7-git-send-email-mohan@in.ibm.com> In-Reply-To: <1323868833-541-7-git-send-email-mohan@in.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig196B77CD0EAC51A35CCDB1D7" Subject: Re: [Qemu-devel] [PATCH V5 06/14] hw/9pfs: Open and create files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "M. Mohan Kumar" Cc: stefanha@gmail.com, qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig196B77CD0EAC51A35CCDB1D7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/14/2011 06:20 AM, M. Mohan Kumar wrote: > From: "M. Mohan Kumar" >=20 > Add interfaces to open and create files for proxy file system driver. >=20 > Signed-off-by: M. Mohan Kumar > --- > fsdev/virtfs-proxy-helper.c | 178 +++++++++++++++++++++++++++++++++++= +++++- > hw/9pfs/virtio-9p-proxy.c | 187 +++++++++++++++++++++++++++++++++++= ++++++-- > hw/9pfs/virtio-9p-proxy.h | 11 +++ > 3 files changed, 367 insertions(+), 9 deletions(-) >=20 > +static int setfsugid(int uid, int gid) > +{ > + /* > + * We still need DAC_OVERRIDE because we don't change > + * supplementary group ids, and hence may be subjected DAC rules > + */ > + cap_value_t cap_list[] =3D { > + CAP_DAC_OVERRIDE, > + }; > + > + setfsgid(gid); > + setfsuid(uid); Fedora 17 now complains about this: CC fsdev/virtfs-proxy-helper.o fsdev/virtfs-proxy-helper.c: In function =E2=80=98setfsugid=E2=80=99: fsdev/virtfs-proxy-helper.c:293:13: error: ignoring return value of =E2=80=98setfsgid=E2=80=99, declared with attribute warn_unused_result [-Werror=3Dunused-result] fsdev/virtfs-proxy-helper.c:294:13: error: ignoring return value of =E2=80=98setfsuid=E2=80=99, declared with attribute warn_unused_result [-Werror=3Dunused-result] --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig196B77CD0EAC51A35CCDB1D7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQbaI5AAoJEKeha0olJ0Nq0r0H/jSuLZjHiJvBo9nete5YuwYG 6/yRJRIbDDmjNJkEWVMivCUJ6bZpEamo3lL+MSpnWUxUzycwbZl1KKck9i23S3DJ r73iSkGqtQ/dQwWVSN+7uiuomtTYX+fJ/h6to7ndpx9zfyP/SNk6UuX8VcZTFytB MqNgyOG6IX4jxYwZ7/RbwGVsk3wrvIIolGmi0rLfiuAcyiz+kXRSUjxW1yNSm8C1 T96vVWqlivYEG5bkl2yyHrxhxl8rMsQwqgA+0naUC2519OCER2tKg62V8iotBB4C xOa5/LglPZ9I+DFiCVZR7YOMpHy8gzg3GHZckhsg/5TQ1VdNgpNnseNmGZe3lN0= =0Y6N -----END PGP SIGNATURE----- --------------enig196B77CD0EAC51A35CCDB1D7--