From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJo6C-0004YZ-Pn for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:16:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJo5w-00048i-I7 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:16:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJo5w-00048H-A1 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:16:16 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q94GGF5c000371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 4 Oct 2012 12:16:15 -0400 Message-ID: <506DB64D.4030800@redhat.com> Date: Thu, 04 Oct 2012 18:16:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349275025-5093-1-git-send-email-pbonzini@redhat.com> <1349275025-5093-2-git-send-email-pbonzini@redhat.com> <20121004131456.1741007c@doriath.home> In-Reply-To: <20121004131456.1741007c@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org Il 04/10/2012 18:14, Luiz Capitulino ha scritto: >> > +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, >> > + const char *fmt, ...) > > The function's name makes me expect that something else is done with os_errno ^^^^ Why something "else"? :) > other than appending the strerror() string to the user message, but I can't > suggest anything better (and allows for storing errno in the Error object in > the future if we want to). Who knows... :) Paolo