From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH v2] qemu-options.hx: Change from recommending '?' to 'help'
Date: Thu, 04 Oct 2012 10:19:43 -0600 [thread overview]
Message-ID: <506DB71F.80501@redhat.com> (raw)
In-Reply-To: <1349364121-29823-1-git-send-email-peter.maydell@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
On 10/04/2012 09:22 AM, Peter Maydell wrote:
> Update the -help output and documentation so that it recommends
> 'help' rather than '?' for the various "list valid values for this
> option" cases. '?' is deprecated (as it can fail confusingly if
> not quoted), so it's better to steer users towards 'help'. ('?'
> still works, for backwards compatibility.)
>
> This is the -help option part of the change otherwise done in
> commit c8057f9, since we are now past release 1.2 and free to
> change our help text without worrying about breaking libvirt.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> v1->v2: added quoting to '-foo help' in various places
> (I don't entirely agree with Eric about this but it will
> probably help to unblock this patch)
I wasn't entirely opposed to your proposed v1 approach of minimal diff,
and saving formatting for a separate patch; but now that you've done the
work, v2 is also nice and relatively easy to follow. Yes, I also hope
this unblocks the patch.
>
> NB: v1 of this patch got a:
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> but I'm guessing you meant that to be a Reviewed-by or Acked-by ?
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 617 bytes --]
next prev parent reply other threads:[~2012-10-04 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 15:22 [Qemu-devel] [PATCH v2] qemu-options.hx: Change from recommending '?' to 'help' Peter Maydell
2012-10-04 16:19 ` Eric Blake [this message]
2012-10-18 12:45 ` Peter Maydell
2012-10-19 19:33 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506DB71F.80501@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).