From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJo9U-0007c1-Si for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:20:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJo9O-0005Ju-F4 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:19:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJo9O-0005JU-65 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:19:50 -0400 Message-ID: <506DB71F.80501@redhat.com> Date: Thu, 04 Oct 2012 10:19:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349364121-29823-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1349364121-29823-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig32C8170EDAB971D1291B2680" Subject: Re: [Qemu-devel] [PATCH v2] qemu-options.hx: Change from recommending '?' to 'help' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , qemu-devel@nongnu.org, patches@linaro.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig32C8170EDAB971D1291B2680 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/04/2012 09:22 AM, Peter Maydell wrote: > Update the -help output and documentation so that it recommends > 'help' rather than '?' for the various "list valid values for this > option" cases. '?' is deprecated (as it can fail confusingly if > not quoted), so it's better to steer users towards 'help'. ('?' > still works, for backwards compatibility.) >=20 > This is the -help option part of the change otherwise done in > commit c8057f9, since we are now past release 1.2 and free to > change our help text without worrying about breaking libvirt. >=20 > Signed-off-by: Peter Maydell > --- > v1->v2: added quoting to '-foo help' in various places > (I don't entirely agree with Eric about this but it will > probably help to unblock this patch) I wasn't entirely opposed to your proposed v1 approach of minimal diff, and saving formatting for a separate patch; but now that you've done the work, v2 is also nice and relatively easy to follow. Yes, I also hope this unblocks the patch. >=20 > NB: v1 of this patch got a: > Signed-off-by: Daniel P. Berrange > but I'm guessing you meant that to be a Reviewed-by or Acked-by ? Reviewed-by: Eric Blake --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig32C8170EDAB971D1291B2680 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQbbchAAoJEKeha0olJ0Nqp0kIAIzQMMYXfnbUgRMEnw0E7NGk aqwKCYfjRR50DSCdwHBtaS1TPNIfcQ9pqTs11UVZSC9QWyGSPqDrY8qOOWs2qH7P C7KbxSkt1MzG0J1hjOLmBM3VqEZnHuHrRc0rUw+nwEQDVetcCPbYz2uzd7wUycJf B6zWF5XTVIsk2pbYzWaL8iUUTzOqvxrsLu/11+GoCAVwFUj0hhlNotJ1j28eX8Ig xV674skS1sr+1SN7YxdZFl0wIaqdQyVlJIjfxjmMnuZhoT2yip3pcqH/8PA2IFFt +0skc6e8UgPLDFtr6t76tclVsyF39amdp3/7arcThrLsS1nW8MMAFm+zNWODHkI= =43kn -----END PGP SIGNATURE----- --------------enig32C8170EDAB971D1291B2680--