From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJokp-0004eJ-P8 for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:58:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJokl-0007f0-PQ for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:58:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25379) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJokl-0007ec-HH for qemu-devel@nongnu.org; Thu, 04 Oct 2012 12:58:27 -0400 Message-ID: <506DC02E.6050101@redhat.com> Date: Thu, 04 Oct 2012 18:58:22 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1349280245-16341-1-git-send-email-avi@redhat.com> <1349280245-16341-4-git-send-email-avi@redhat.com> <506D2DAD.2060809@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v1 03/22] kvm: use separate MemoryListeners for memory and I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Paolo Bonzini , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Anthony Liguori , liu ping fan On 10/04/2012 06:44 PM, Blue Swirl wrote: > On Thu, Oct 4, 2012 at 6:33 AM, Avi Kivity wrote: >> On 10/03/2012 10:16 PM, Blue Swirl wrote: >>> > +static MemoryListener kvm_io_listener = { >>> >>> const >>> >> >> There is a list link field in there. It's a mixed data/ops structure >> (perhaps we should make it a traditional ->ops-> pointer). > > I grepped for MemoryListener and in hw/xen_pt.c 'const' already > exists, so it looked OK but the code actually copies the structure to > writable memory. Yes. We should probably switch to the standard object->ops->callback pattern. I'll write a patch after this series is merged. -- error compiling committee.c: too many arguments to function