From: Paolo Bonzini <pbonzini@redhat.com>
To: "Søren Sandmann" <sandmann@cs.au.dk>
Cc: "Søren Sandmann Pedersen" <ssp@redhat.com>,
qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when spice-server is new enough
Date: Fri, 05 Oct 2012 09:21:31 +0200 [thread overview]
Message-ID: <506E8A7B.6040900@redhat.com> (raw)
In-Reply-To: <ye8391ucfex.fsf@llama05.cs.au.dk>
Il 04/10/2012 19:31, Søren Sandmann ha scritto:
>> >
>> > No, that's not possible. The revision must be the same for all machines
>> > started with the same "-M" argument. So your only choice is to make
>> > 0.12 a requirement for QEMU 1.3. Then you can use compatibility
>> > properties (see the long list of strings in hw/pc_piix.c) to ensure that
>> > pc-1.2 and earlier machines use the previous revision.
> Spice server 0.12 is already, so I'll send a patch to require that
> unconditionally. I'm assuming that later strings override earlier ones
> so that the revision=3 I added won't take effect for previous machines.
There is a PC_COMPAT_1_2 macro, just add the
{\
.driver = "qxl-vga",\
.property = "revision",\
.value = "3",\
},{\
{\
.driver = "qxl",\
.property = "revision",\
.value = "3",\
},{\
there.
Paolo
prev parent reply other threads:[~2012-10-05 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 17:57 [Qemu-devel] [PATCH] qxl: Default to PCI revision 4 when spice-server is new enough Søren Sandmann
2012-10-04 9:44 ` Paolo Bonzini
2012-10-04 17:31 ` Søren Sandmann
2012-10-04 17:37 ` [Qemu-devel] [PATCH] Require spice-server 0.12.0 and spice-protocol 0.12.2 Søren Sandmann
2012-10-05 7:25 ` Paolo Bonzini
2012-10-05 14:02 ` Søren Sandmann
2012-10-08 7:33 ` Gerd Hoffmann
2012-10-05 7:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506E8A7B.6040900@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sandmann@cs.au.dk \
--cc=ssp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).