From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39486)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK3DF-0003KY-Kd
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 04:24:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK3D7-0001K6-Rf
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 04:24:49 -0400
Received: from mx1.redhat.com ([209.132.183.28]:6901)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TK3D7-0001Jx-JG
	for qemu-devel@nongnu.org; Fri, 05 Oct 2012 04:24:41 -0400
Message-ID: <506E993E.2090001@redhat.com>
Date: Fri, 05 Oct 2012 10:24:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1349372021-31212-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1349372021-31212-23-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1349372021-31212-23-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 22/22] qidl: unit tests and build
	infrastructure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com

Il 04/10/2012 19:33, Michael Roth ha scritto:
> +
> +%.qidl.c: %.c $(SRC_PATH)/qidl.h $(addprefix $(SRC_PATH)/scripts/,lexer.py qidl.py qidl_parser.py qapi.py qapi_visit.py)
> +	$(call rm -f $(*D)/qidl-generated/$(*F).qidl.c)
> +	$(if $(strip $(shell grep "QIDL_ENABLE()" $< 1>/dev/null && echo "true")), \
> +	  $(call quiet-command, \
> +	    $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(CFLAGS) -E -c -DQIDL_GEN $< | \
> +	    $(PYTHON) $(SRC_PATH)/scripts/qidl.py \
> +	    --output-filepath=$(*D)/qidl-generated/$(*F).qidl.c || [ "$$?" -eq 2 ], \
> +	    "qidl PP $(*D)/$(*F).c"),)
> +%.o: %.c %.qidl.c
> +	$(if $(strip $(shell test -f $(*D)/qidl-generated/$(*F).qidl.c && echo "true")), \
> +	  $(call quiet-command, \
> +	    $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c \
> +		-DQIDL_ENABLED -include $< -o $@ $(*D)/qidl-generated/$(*F).qidl.c, \
> +		"qidl CC $@"), \
> +	  $(call quiet-command, \
> +	    $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c \
> +	      -o $@ $<,"  CC    $@"))


Because the .qidl.c files are not created for files without a QIDL_ENABLE()
directive, all those files will be grepped on every invocation of the makefile.

It is better to define the list of QIDL_ENABLEd files in an auxiliary makefile
like this (untested):

QIDL_FILES =
-include qemu-idl-files.mak
qemu-idl-files.mak: $(obj-y) $(common-obj-y) $(hw-obj-y)
	(grep -l "QIDL_ENABLE()" $^ || :) | sed 's/^/QIDL_FILES += /' > $@

$(QIDL_FILES): %.qidl.c: %.c
	$(call quiet-command, \
	    $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(CFLAGS) -E -c -DQIDL_GEN $< | \
	    $(PYTHON) $(SRC_PATH)/scripts/qidl.py \
	    --output-filepath=$(*D)/qidl-generated/tmp-$(*F).qidl.c || [ "$$?" -eq 2 ], \
	    "qidl PP $(*D)/$(*F).c"),)
	mv $(*D)/qidl-generated/tmp-$(*F).qidl.c $(*D)/qidl-generated/$(*F).qidl.c

$(QIDL_FILES): %.o: %.c %.qidl.c
	$(call quiet-command, \
	    $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c \
		-DQIDL_ENABLED -include $< -o $@ $(*D)/qidl-generated/$(*F).qidl.c, \
		"qidl CC $@"), \

%.o: %.c
	$(call quiet-command, \
	    $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c \
	      -o $@ $<,"  CC    $@"))

Paolo