From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK69A-0007NM-Aq for qemu-devel@nongnu.org; Fri, 05 Oct 2012 07:32:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK694-0004Kc-Da for qemu-devel@nongnu.org; Fri, 05 Oct 2012 07:32:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK694-0004KR-68 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 07:32:42 -0400 Message-ID: <506EC542.20707@redhat.com> Date: Fri, 05 Oct 2012 13:32:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1348906418-16471-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1348906418-16471-6-git-send-email-xiawenc@linux.vnet.ibm.com> <506C2206.7030809@163.com> <506C2DDD.6090500@redhat.com> <506EC26F.4020002@163.com> In-Reply-To: <506EC26F.4020002@163.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V5 5/5] libqblock test example List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: wenchao xia Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com, Wenchao Xia Il 05/10/2012 13:20, wenchao xia ha scritto: > > > Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see > > > what it really is. It is actually defined in internal header files. > > > > Yes, but even the type should be hidden. It should be purely an > > implementation detail, at least for now, to hide the switch in a single > > function. > > OK, then I'll remove it. Do you think there is other things need to > be modified? I don't recall anything. Paolo