From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK7Ix-0002JR-Ck for qemu-devel@nongnu.org; Fri, 05 Oct 2012 08:47:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK7Is-0000BR-K1 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 08:46:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK7Is-0000A9-BZ for qemu-devel@nongnu.org; Fri, 05 Oct 2012 08:46:54 -0400 Message-ID: <506ED6B8.9020306@redhat.com> Date: Fri, 05 Oct 2012 14:46:48 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349388419-21924-1-git-send-email-lmr@redhat.com> <1349388419-21924-2-git-send-email-lmr@redhat.com> <506E8C53.5050107@redhat.com> <87ehldccsj.fsf@codemonkey.ws> <506ED5DF.9030007@siemens.com> In-Reply-To: <506ED5DF.9030007@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Lucas Meneghel Rodrigues , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-devel , Anthony Liguori Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>> >> This "| 1" might be the problem. Anthony, are you relying on it in >>> >> qemu-test and/or can you work out the changes if we use just >>> >> "exit(val)"? >> > >> > The reason for ' | 1' was to make sure that the guest couldn't trigger >> > an exit(0). >> > >> > If there's a compelling reason to drop '| 1', I can adjust my tests >> > accordingly. > assert(val); (or hw_error) > exit(val); > > I would suggest. I think what the kvm_unittests want is exactly to trigger an exit(0). Why did you rule it out? Paolo