From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK8h9-0007Zi-0i for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:16:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TK8h7-0004La-Pg for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:16:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TK8h7-0004LN-Gn for qemu-devel@nongnu.org; Fri, 05 Oct 2012 10:16:01 -0400 Message-ID: <506EEB96.2070706@redhat.com> Date: Fri, 05 Oct 2012 16:15:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1349388419-21924-1-git-send-email-lmr@redhat.com> <1349388419-21924-2-git-send-email-lmr@redhat.com> <506E8C53.5050107@redhat.com> <87ehldccsj.fsf@codemonkey.ws> <506ED5DF.9030007@siemens.com> <506ED6B8.9020306@redhat.com> <87ehld6mw2.fsf@codemonkey.ws> In-Reply-To: <87ehld6mw2.fsf@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Lucas Meneghel Rodrigues , Jan Kiszka , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , qemu-devel Il 05/10/2012 15:58, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>>>>>> This "| 1" might be the problem. Anthony, are you relying on it in >>>>>>> qemu-test and/or can you work out the changes if we use just >>>>>>> "exit(val)"? >>>>> >>>>> The reason for ' | 1' was to make sure that the guest couldn't trigger >>>>> an exit(0). >>>>> >>>>> If there's a compelling reason to drop '| 1', I can adjust my tests >>>>> accordingly. >>> assert(val); (or hw_error) >>> exit(val); >>> >>> I would suggest. >> >> I think what the kvm_unittests want is exactly to trigger an exit(0). >> Why did you rule it out? > > Mainly to differientiate between an open coded exit(0)/exit(1) and > something triggered by the unit test. > > The problem I tried to cope with was: > > anthony@titi:~/git/qemu$ grep 'exit([01])' hw/*.c | wc -l > 249 Understood. The right solution is of course to fix hw/*.c. Let's start with exit(0). hw/eeprom93xx.c: exit(0); <--- should be hw_error hw/pci.c: exit(0); <--- move to qemu_show_nic_models hw/spapr.c: exit(0); <--- should be exit(1) !! For exit(1), many of them should become hw_error, especially those in this files: hw/bonito.c hw/ivshmem.c hw/lsi53c895a.c hw/pci.c hw/pl022.c hw/pl061.c hw/pl110.c hw/qxl.c hw/smbus.c hw/ssd0303.c hw/ssi-sd.c hw/stellaris_enet.c hw/virtio-blk.c hw/virtio.c hw/virtio-net.c hw/virtio-scsi.c Any takers? Paolo