From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCbT-00049d-Qm for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:26:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TKCbS-0003AN-JP for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:26:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TKCbS-0003AD-95 for qemu-devel@nongnu.org; Fri, 05 Oct 2012 14:26:26 -0400 Message-ID: <506F2648.2020605@redhat.com> Date: Fri, 05 Oct 2012 12:26:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1349460425-30601-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1349460425-30601-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigAED672B2A6795DBC86304705" Subject: Re: [Qemu-devel] [PATCH 0/4] command line fd passing using fd sets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: libvir-list@redhat.com, kwolf@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigAED672B2A6795DBC86304705 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 10/05/2012 12:07 PM, Corey Bryant wrote: > This series adds command line file descriptor passing support > to the -drive option. This is a follow-on to the existing > QMP fd passing support provided in the following patch series: > comments.gmane.org/gmane.comp.emulators.qemu/165463 >=20 > An example of using the new -drive fd and opaque options: > qemu-kvm -drive fd=3D24,opaque=3D"rdwr:/path/file",index=3D0,media=3Ddi= sk This feels wrong. Now you have to special-case encode the fd=3Dnn,opaque=3Dxyz handling to EVERY command line argument that takes a= file name, not just -drive. I'd much rather see: qemu-kvm -fdset set=3D1,fds=3D24,25 \ -drive file=3D/def/fdset/1,index=3D0,media=3Ddisk Where the creation of fdsets happens independently from use of those sets, and therefore all other arguments that take file names can just magically take the /dev/fdset/nnn notation that we already support from the monitor. Besides, my approach will let me pass in an O_RDONLY fd on 24 and O_RDWR on 25 into the same set, whereas your approach creates a new set per fd, so I can't add new fds to the set until the monitor is up and running. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigAED672B2A6795DBC86304705 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQEcBAEBCAAGBQJQbyZJAAoJEKeha0olJ0NqjekH/ihV0VpUlJnY+d9rCAa1iiA0 kwX2iZf/SvCNgr97r1tBbHP2HxU06hyNTZvc68Yut1EzOVzEqKmaH4I8Q5Zc2GCy 0CasRGZkhZS2XRffcW/g2XQpFOSTRjnWN0VJKh90pBfeKGFvyhvVuH5cPGPzoEWR /yEapiTSbvrrk9I1eHm6RiZ2DfEL9Fq8JD8bUMHOeYwDtO4jMDCDKpQfWmVvnbuG l5zsTJ7Mv2PahueD3m+MUcON/Do1MjQ7g9h8vN5OgNkhEbsY5vMbtFgTCHzjm2qB ssEU0aXhKsboq/u6tqJWCuR1lLqNzJpIVo1yNm40i9DRrmfBa88yBYqQR9jXVYI= =cj+e -----END PGP SIGNATURE----- --------------enigAED672B2A6795DBC86304705--